Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve warnings and remove deprecated code #729

Merged
merged 33 commits into from
Nov 30, 2024
Merged

Conversation

bumbummen99
Copy link
Collaborator

As the title says, this Pull Request will solve thrown Warnings and remove deprecated code.

Close #726

[Change] Drop use of soon to be removed utf8_encode / utf8_decode functions,
[Change] Prevent sprintf template being null on getJoinLink(),
[Fix] Protocols::joinLink default value and type hints,
[Change] Refactor Stripcolors filter implementation
@bumbummen99 bumbummen99 added Enhancement This request does add something to the project. Security This request does increase security of the package. labels Nov 28, 2024
@bumbummen99 bumbummen99 self-assigned this Nov 28, 2024
… in simple manner,

[Change] Refactor Iterators in Filters with applyRecursively,
[Change] Refactor Normalize Filter
@coveralls
Copy link

coveralls commented Nov 28, 2024

Coverage Status

coverage: 93.762% (-0.1%) from 93.905%
when pulling 4f34167 on remove_deprecated_function
into e9a315a on v3.

@scrutinizer-notifier
Copy link

The inspection completed: 5 new issues, 12 updated code elements

@bumbummen99 bumbummen99 merged commit 37cdd6d into v3 Nov 30, 2024
13 checks passed
@bumbummen99 bumbummen99 deleted the remove_deprecated_function branch December 2, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This request does add something to the project. Security This request does increase security of the package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GameSpy3 protocol 'Function utf8_encode() is deprecated'
3 participants