Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add operator #12

Merged
merged 12 commits into from
May 19, 2024
Merged

Add operator #12

merged 12 commits into from
May 19, 2024

Conversation

winklermichael
Copy link
Collaborator

No description provided.

@winklermichael winklermichael self-assigned this May 19, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

Unit Test Results

11 tests   11 ✔️  0s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 87c9e47.

@kevinwielander
Copy link
Collaborator

looks good to me, nothing serious id change other than minor refactoring but thats out of scope for the poc. How will the envs be set down the line btw ? i mean it wond be an .env file I believe

@winklermichael
Copy link
Collaborator Author

i agree that this would need refactoring and that this is out of scope for the poc.

in the final deployment the env would be set via helm chart, you would configure the specific values in the values.yaml file and the operator deployment would mount those values using a configmap

@winklermichael winklermichael merged commit 17b8ca9 into dev May 19, 2024
6 checks passed
@winklermichael winklermichael deleted the feature/operator branch May 19, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants