fix: fix non-unique instance id in the node (#798)

Signed-off-by: wangxye <xuanyewang.cs@gmail.com>
AutoMQ · Dec 5, 2023 · 99c0fb7 · 99c0fb7
1 parent a6bf037
commit 99c0fb7
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/...oller/src/main/java/com/automq/rocketmq/controller/server/store/DefaultMetadataStore.java b/...oller/src/main/java/com/automq/rocketmq/controller/server/store/DefaultMetadataStore.java
@@ -297,11 +297,14 @@ public CompletableFuture<Node> registerBrokerNode(String name, String address, S
                 if (this.isLeader()) {
                     try (SqlSession session = openSession()) {
                         NodeMapper nodeMapper = session.getMapper(NodeMapper.class);
-                        Node node = nodeMapper.get(null, name, instanceId, null);
+                        Node node = nodeMapper.get(null, name, null, null);
                         if (null != node) {
                             if (!Strings.isNullOrEmpty(address)) {
                                 node.setAddress(address);
                             }
+                            if (!Strings.isNullOrEmpty(instanceId)) {
+                                node.setInstanceId(instanceId);
+                            }
                             node.setEpoch(node.getEpoch() + 1);
                             nodeMapper.update(node);
                         } else {