Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3stream/wal): merge write #454

Merged
merged 5 commits into from
Oct 24, 2023
Merged

feat(s3stream/wal): merge write #454

merged 5 commits into from
Oct 24, 2023

Conversation

Chillax-0v0
Copy link
Contributor

solve #171

Signed-off-by: Ning Yu <ningyu@automq.com>
Signed-off-by: Ning Yu <ningyu@automq.com>
@Chillax-0v0 Chillax-0v0 added enhancement New feature or request s3stream wal the WAL of S3 stream labels Oct 24, 2023
@Chillax-0v0 Chillax-0v0 self-assigned this Oct 24, 2023
@Chillax-0v0 Chillax-0v0 marked this pull request as draft October 24, 2023 11:17
@Chillax-0v0 Chillax-0v0 linked an issue Oct 24, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #454 (d3fa14c) into main (e1ef4f9) will decrease coverage by 0.05%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #454      +/-   ##
============================================
- Coverage     57.38%   57.33%   -0.05%     
- Complexity      812      817       +5     
============================================
  Files            99       99              
  Lines          6084     6084              
  Branches        577      577              
============================================
- Hits           3491     3488       -3     
  Misses         2260     2260              
- Partials        333      336       +3     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 12.50% <ø> (ø)
RocketMQ Controller 58.35% <ø> (-0.11%) ⬇️
RocketMQ Proxy 37.69% <ø> (ø)
RocketMQ Store 74.51% <ø> (ø)
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 16.98% <ø> (ø)

see 6 files with indirect coverage changes

@github-actions
Copy link

github-actions bot commented Oct 24, 2023

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Signed-off-by: Ning Yu <ningyu@automq.com>
Signed-off-by: Ning Yu <ningyu@automq.com>
Signed-off-by: Ning Yu <ningyu@automq.com>
@Chillax-0v0 Chillax-0v0 marked this pull request as ready for review October 24, 2023 13:08
@superhx superhx merged commit 3fc2224 into main Oct 24, 2023
8 of 9 checks passed
@superhx superhx deleted the feat-wal-merge-write branch October 24, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request s3stream wal the WAL of S3 stream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WAL] Writing multiple records in one block to support RocketMQ
2 participants