fix(s3stream): compaction fix #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SCNieh
commented
Oct 30, 2023
•
SCNieh
commented
- change copyAndWrite to readAndWrite in force split to reduce S3 API invocation
- limit memory consumption in force split
- separate force split and compaction into different commit request
1. wait for force split done before do WAL compaction 2. sanity check covers only compacted objects Signed-off-by: Shichao Nie <niesc@automq.com>
|
The author of this PR, SCNieh, is not an activated member of this organization on Codecov. |
Qodana for JVM3 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
1. change copyAndWrite to readAndWrite in force split to reduce S3 API invocation 2. limit memory consumption in force split 3. separate force split and compaction into different commit request Signed-off-by: Shichao Nie <niesc@automq.com>
Signed-off-by: Shichao Nie <niesc@automq.com>
superhx
reviewed
Oct 31, 2023
| pair.getValue().completeExceptionally(ex); | ||
| } | ||
| return null; | ||
| }).join(); |
There was a problem hiding this comment.
The join operation only makes prepareObject sequence.
…teration Signed-off-by: Shichao Nie <niesc@automq.com>
superhx
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.