Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: trim stream prior to deleting objects #578

Merged
merged 2 commits into from
Nov 6, 2023
Merged

feat: trim stream prior to deleting objects #578

merged 2 commits into from
Nov 6, 2023

Conversation

lizhanhui
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 6, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov Codecov
Copy link

codecov bot commented Nov 6, 2023 •
edited
Loading

Codecov Report

Merging #578 (15f3397) into main (bf001d5) will increase coverage by 0.12%.
The diff coverage is 0.00%.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #578      +/-   ##
============================================
+ Coverage     56.14%   56.27%   +0.12%     
- Complexity     1834     1841       +7     
============================================
  Files           196      196              
  Lines         12797    12799       +2     
  Branches       1219     1219              
============================================
+ Hits           7185     7202      +17     
+ Misses         5044     5038       -6     
+ Partials        568      559       -9
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 12.96% <ø> (ø)
RocketMQ Controller 49.27% <ø> (-0.04%) ⬇️
RocketMQ Proxy 44.65% <ø> (+0.20%) ⬆️
RocketMQ Store 78.02% <0.00%> (+0.59%) ⬆️
RocketMQ Stream 60.62% <ø> (+0.03%) ⬆️
RocketMQ Metadata 17.64% <ø> (ø)
Files Coverage Δ
...java/com/automq/rocketmq/common/api/DataStore.java 0.00% <ø> (ø)
...va/com/automq/rocketmq/store/MessageStoreImpl.java 57.33% <ø> (ø)
...ava/com/automq/rocketmq/store/DataStoreFacade.java 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023 •
edited
Loading

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@lizhanhui
feat: trim stream prior to deleting objects
7b0a839 
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
@ShadowySpirits
feat(store): implement DataStore#trimStream
15f3397 
Signed-off-by: SSpirits <admin@lv5.moe>
@lizhanhui lizhanhui merged commit 5626710 into main Nov 6, 2023
8 of 10 checks passed
@lizhanhui lizhanhui deleted the trim_stream branch November 6, 2023 08:04
lizhanhui added a commit that referenced this pull request Nov 7, 2023
@lizhanhui @ShadowySpirits
feat: trim stream prior to deleting objects (#578)
1f0f26c 
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
Signed-off-by: SSpirits <admin@lv5.moe>
Co-authored-by: SSpirits <admin@lv5.moe>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShadowySpirits ShadowySpirits Awaiting requested review from ShadowySpirits

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lizhanhui @CLAassistant @ShadowySpirits