Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3stream): support network throttle with priority #598

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

SCNieh
Copy link
Contributor

@SCNieh SCNieh commented Nov 8, 2023

No description provided.

Signed-off-by: Shichao Nie <niesc@automq.com>
Signed-off-by: Shichao Nie <niesc@automq.com>
@SCNieh SCNieh requested a review from superhx November 8, 2023 07:25
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #598 (01f383e) into main (635db0e) will increase coverage by 0.09%.
The diff coverage is 84.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #598      +/-   ##
============================================
+ Coverage     58.88%   58.98%   +0.09%     
  Complexity     1915     1915              
============================================
  Files           196      196              
  Lines         12837    12828       -9     
  Branches       1220     1217       -3     
============================================
+ Hits           7559     7566       +7     
+ Misses         4672     4652      -20     
- Partials        606      610       +4     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 12.96% <ø> (ø)
RocketMQ Controller 49.31% <ø> (+0.11%) ⬆️
RocketMQ Proxy 44.55% <ø> (ø)
RocketMQ Store 77.66% <ø> (+0.46%) ⬆️
RocketMQ Stream 60.49% <84.00%> (+<0.01%) ⬆️
RocketMQ Metadata 17.64% <ø> (ø)
Files Coverage Δ
...c/main/java/com/automq/stream/s3/ObjectReader.java 85.81% <100.00%> (ø)
.../java/com/automq/stream/s3/StreamObjectCopier.java 83.33% <100.00%> (ø)
...in/java/com/automq/stream/s3/cache/BlockCache.java 75.25% <100.00%> (-0.63%) ⬇️
...mq/stream/s3/compact/operator/DataBlockWriter.java 83.15% <100.00%> (ø)
...com/automq/stream/s3/network/ThrottleStrategy.java 100.00% <100.00%> (ø)
...mq/stream/s3/compact/operator/DataBlockReader.java 59.18% <66.66%> (ø)
...tream/s3/network/AsyncNetworkBandwidthLimiter.java 78.48% <88.88%> (-0.27%) ⬇️
...om/automq/stream/s3/cache/DefaultS3BlockCache.java 80.98% <70.00%> (+1.44%) ⬆️

... and 6 files with indirect coverage changes

Copy link

github-actions bot commented Nov 8, 2023

Qodana for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@superhx superhx merged commit e8aaf94 into main Nov 8, 2023
10 checks passed
@superhx superhx deleted the prior_throttle branch November 8, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants