Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(broker): introduce tracing to both proxy and store modules #606

Merged
merged 5 commits into from
Nov 13, 2023

Conversation

ShadowySpirits
Copy link
Contributor

No description provided.

Signed-off-by: SSpirits <admin@lv5.moe>
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #606 (550998a) into main (992fa4c) will decrease coverage by 0.69%.
The diff coverage is 26.54%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #606      +/-   ##
============================================
- Coverage     59.03%   58.34%   -0.69%     
- Complexity     1939     1946       +7     
============================================
  Files           199      205       +6     
  Lines         13054    13114      +60     
  Branches       1195     1197       +2     
============================================
- Hits           7707     7652      -55     
- Misses         4729     4858     +129     
+ Partials        618      604      -14     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 6.16% <0.00%> (-6.80%) ⬇️
RocketMQ Controller 50.38% <ø> (-0.12%) ⬇️
RocketMQ Proxy 42.90% <55.81%> (-0.42%) ⬇️
RocketMQ Store 77.53% <56.25%> (-0.56%) ⬇️
RocketMQ Stream 60.49% <ø> (+0.03%) ⬆️
RocketMQ Metadata 38.28% <ø> (ø)
Files Coverage Δ
...java/com/automq/rocketmq/store/api/LogicQueue.java 92.30% <ø> (ø)
...m/automq/rocketmq/store/service/ReviveService.java 79.80% <100.00%> (-6.74%) ⬇️
...omq/rocketmq/proxy/service/MessageServiceImpl.java 71.51% <93.33%> (+0.63%) ⬆️
.../java/com/automq/rocketmq/store/S3StreamStore.java 0.00% <0.00%> (ø)
...ketmq/store/service/StreamOperationLogService.java 78.75% <90.90%> (+0.85%) ⬆️
.../com/automq/rocketmq/common/trace/MethodCache.java 0.00% <0.00%> (ø)
...om/automq/rocketmq/proxy/aop/ProxyTraceAspect.java 50.00% <50.00%> (ø)
.../rocketmq/proxy/service/SuspendRequestService.java 62.50% <57.14%> (-1.24%) ⬇️
...va/com/automq/rocketmq/proxy/util/ContextUtil.java 50.00% <50.00%> (ø)
...om/automq/rocketmq/store/aop/StoreTraceAspect.java 50.00% <50.00%> (ø)
... and 8 more

... and 4 files with indirect coverage changes

Copy link

github-actions bot commented Nov 9, 2023

Qodana for JVM

5 new problems were found

Inspection name Severity Problems
Field can be local 🔶 Warning 2
Field may be 'final' 🔶 Warning 1
Optional.get() is called without isPresent() check 🔶 Warning 1
Unchecked warning 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Signed-off-by: SSpirits <admin@lv5.moe>
Signed-off-by: SSpirits <admin@lv5.moe>
Signed-off-by: SSpirits <admin@lv5.moe>
Signed-off-by: SSpirits <admin@lv5.moe>
@ShadowySpirits ShadowySpirits merged commit 0acafb7 into main Nov 13, 2023
8 of 10 checks passed
@ShadowySpirits ShadowySpirits deleted the tracing branch November 13, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant