Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(s3stream): rename sst to stream set object #609

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

superhx
Copy link
Contributor

@superhx superhx commented Nov 9, 2023

No description provided.

Signed-off-by: Robin Han <hanxvdovehx@gmail.com>
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #609 (f80af39) into main (992fa4c) will increase coverage by 0.00%.
The diff coverage is 66.43%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #609   +/-   ##
=========================================
  Coverage     59.03%   59.04%           
- Complexity     1939     1944    +5     
=========================================
  Files           199      199           
  Lines         13054    13054           
  Branches       1195     1195           
=========================================
+ Hits           7707     7708    +1     
  Misses         4729     4729           
+ Partials        618      617    -1     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 12.96% <ø> (ø)
RocketMQ Controller 50.42% <ø> (-0.08%) ⬇️
RocketMQ Proxy 43.45% <ø> (+0.12%) ⬆️
RocketMQ Store 78.03% <25.00%> (-0.05%) ⬇️
RocketMQ Stream 60.49% <68.84%> (+0.03%) ⬆️
RocketMQ Metadata 38.28% <ø> (ø)
Files Coverage Δ
.../automq/stream/s3/StreamObjectsCompactionTask.java 69.07% <100.00%> (ø)
.../com/automq/stream/s3/compact/CompactionStats.java 90.90% <100.00%> (ø)
...om/automq/stream/s3/metadata/S3ObjectMetadata.java 40.81% <ø> (ø)
...va/com/automq/stream/s3/metadata/S3ObjectType.java 50.00% <100.00%> (ø)
...tream/s3/objects/CommitStreamSetObjectRequest.java 76.47% <100.00%> (ø)
...ream/s3/objects/CommitStreamSetObjectResponse.java 100.00% <100.00%> (ø)
.../stream/s3/objects/CompactStreamObjectRequest.java 40.74% <100.00%> (ø)
...ava/com/automq/rocketmq/store/S3ObjectManager.java 92.30% <100.00%> (ø)
.../java/com/automq/stream/s3/DeltaWALUploadTask.java 93.33% <92.85%> (ø)
.../src/main/java/com/automq/stream/s3/S3Storage.java 60.63% <33.33%> (ø)
... and 6 more

... and 5 files with indirect coverage changes

Signed-off-by: Robin Han <hanxvdovehx@gmail.com>
Copy link

github-actions bot commented Nov 9, 2023

Qodana for JVM

1 new problem were found

Inspection name Severity Problems
Field can be local 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@superhx superhx merged commit f6fcf56 into main Nov 9, 2023
10 checks passed
@superhx superhx deleted the rename_sst branch November 9, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants