Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #716 invoke data-store to potentially delete S3 Object prior to rollback expired prepare-records #717

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

lizhanhui
Copy link
Contributor

No description provided.

…lete expired prepare-records

Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #717 (abc3aac) into main (670b671) will decrease coverage by 0.09%.
The diff coverage is 14.28%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #717      +/-   ##
============================================
- Coverage     57.54%   57.45%   -0.09%     
- Complexity     1220     1224       +4     
============================================
  Files           131      131              
  Lines          8003     8029      +26     
  Branches        736      736              
============================================
+ Hits           4605     4613       +8     
- Misses         2999     3020      +21     
+ Partials        399      396       -3     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 54.88% <12.12%> (-0.26%) ⬇️
RocketMQ Proxy 42.75% <ø> (+0.12%) ⬆️
RocketMQ Store 76.98% <ø> (+0.04%) ⬆️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.29% <ø> (ø)
Files Coverage Δ
...mq/controller/server/store/impl/StreamManager.java 66.26% <100.00%> (+0.31%) ⬆️
...tmq/controller/server/tasks/DataRetentionTask.java 4.34% <0.00%> (+0.42%) ⬆️
...automq/rocketmq/metadata/dao/S3ObjectCriteria.java 72.22% <50.00%> (-6.35%) ⬇️
...rocketmq/metadata/service/cache/S3ObjectCache.java 16.27% <0.00%> (-1.67%) ⬇️
...q/controller/server/tasks/ReclaimS3ObjectTask.java 4.00% <0.00%> (-2.67%) ⬇️

... and 2 files with indirect coverage changes

@ShadowySpirits ShadowySpirits merged commit 58e24aa into main Nov 24, 2023
10 of 14 checks passed
@ShadowySpirits ShadowySpirits deleted the 716-bugfix branch November 24, 2023 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BugFix: Invoke DataStore to delete potentially S3 Object if a prepared S3Object is expired
2 participants