Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(s3stream/storage): calculate the confirm offset from unordered requests #743

Merged
merged 4 commits into from
Nov 28, 2023
Merged

fix(s3stream/storage): calculate the confirm offset from unordered requests #743

merged 4 commits into from
Nov 28, 2023

Conversation

Chillax-0v0
Copy link
Contributor

No description provided.

@Chillax-0v0 Chillax-0v0 added bug Something isn't working s3stream wal the WAL of S3 stream labels Nov 27, 2023
@Chillax-0v0 Chillax-0v0 self-assigned this Nov 27, 2023
@Chillax-0v0 Chillax-0v0 mentioned this pull request Nov 28, 2023
Closed
@Chillax-0v0
fix(s3stream/storage): calculate the confirm offset from unordered re…
a7a3072 
…quests

Signed-off-by: Ning Yu <ningyu@automq.com>
@Chillax-0v0
refactor: calculate the confirm offset by calculator rather than sequ…
206e28f 
…encer

Signed-off-by: Ning Yu <ningyu@automq.com>
@Chillax-0v0
fix: remove all records whose offset is not larger than the confirmed…
c5a4209 
… offset

Signed-off-by: Ning Yu <ningyu@automq.com>
@Chillax-0v0
test: test calculator
b303fb4 
Signed-off-by: Ning Yu <ningyu@automq.com>
@Chillax-0v0 Chillax-0v0 force-pushed the fix-s3storage-wal-confirm-offset-2 branch from 556cd58 to b303fb4 Compare November 28, 2023 03:11
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2023 •
edited
Loading

Codecov Report

Merging #743 (b303fb4) into main (2bac396) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #743      +/-   ##
============================================
- Coverage     57.36%   57.32%   -0.04%     
+ Complexity     1224     1221       -3     
============================================
  Files           131      131              
  Lines          8047     8047              
  Branches        736      736              
============================================
- Hits           4616     4613       -3     
  Misses         3035     3035              
- Partials        396      399       +3
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 54.60% <ø> (ø)
RocketMQ Proxy 42.62% <ø> (-0.13%) ⬇️
RocketMQ Store 76.96% <ø> (-0.05%) ⬇️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)

see 2 files with indirect coverage changes

@superhx superhx merged commit f52f72a into main Nov 28, 2023
9 of 11 checks passed
@superhx superhx deleted the fix-s3storage-wal-confirm-offset-2 branch November 28, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superhx superhx superhx approved these changes

Assignees

@Chillax-0v0 Chillax-0v0

Labels
bug Something isn't working s3stream wal the WAL of S3 stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chillax-0v0 @superhx