Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update pre-commit hooks and add into workflow #16

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ci: update pre-commit hooks and add into workflow #16

wants to merge 2 commits into from

Conversation

benwandrew
Copy link
Contributor

Description

updates pre-commit yaml file and adds new workflow to test the hooks upon PR

Type of change

  • ci: Changes to our CI configuration files and scripts (i.e., those in the .github directory)

@benwandrew benwandrew changed the title ci: update pre commit hooks and add into workflow ci: update pre-commit hooks and add into workflow Sep 13, 2023
hollandjg
hollandjg requested changes Sep 27, 2023
View reviewed changes
Copy link
Member

@hollandjg hollandjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this needs the same updates as on the other PR. Framework looks good though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hollandjg hollandjg hollandjg requested changes

@musslick musslick Awaiting requested review from musslick

@chadcwilliams chadcwilliams Awaiting requested review from chadcwilliams

@younesStrittmatter younesStrittmatter Awaiting requested review from younesStrittmatter

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benwandrew @hollandjg