This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
Remove stately from queue internals #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benasher44
commented
Dec 21, 2019
| @@ -19,7 +18,7 @@ import kotlinx.coroutines.runBlocking | |||
| * Holds the hook for handling background uncaught exceptions | |||
| */ | |||
| @SharedImmutable | |||
| private val UNHANDLE_EXCEPTION_HOOK = AtomicReference<((Throwable) -> Unit)?>(null) | |||
| private val UNHANDLED_EXCEPTION_HOOK = AtomicReference<((Throwable) -> Unit)?>(null) | |||
benasher44
commented
Dec 21, 2019
| @@ -18,12 +16,12 @@ private class WeightedWorker( | |||
| val lastSequence = AtomicLong(0) | |||
|
|
|||
| /** Number of blocks queued on this worker */ | |||
| val numBlocksQueue = AtomicLong(0) | |||
| val numBlocksQueued = AtomicLong(0) | |||
benasher44
commented
Dec 21, 2019
src/nativeMain/kotlin/com/autodesk/coroutineworker/BackgroundCoroutineWorkQueueExecutor.kt
Outdated
Show resolved
Hide resolved
benasher44
force-pushed
the
basher/refactor-queue
branch
from
9c717cd
to
37f24e1
Compare
benasher44
force-pushed
the
basher/refactor-cancel
branch
from
ec2bc0f
to
cb12dd3
Compare
benasher44
force-pushed
the
basher/refactor-queue
branch
from
37f24e1
to
21763ed
Compare
DanielRBaird
approved these changes
Dec 22, 2019
benasher44
force-pushed
the
basher/refactor-queue
branch
from
21763ed
to
747080a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the one case I needed a lock and shared collection, I switched to a Worker and a mutable (only accessed from that Worker) linked list. Otherwise, I switched to a lock-free implementation and used available native primitives.