EMSUSD-1519 Collections: remove all includes and excludes #4058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Dec 20, 2024
•
pierrebai-adsk
commented
- Add to the data classes a function to remove all includes and excludes.
- Add to the UI a menu item to remove all includes and excludes.
- Make the UI call the data when triggered.
- Make menu item separators show up even as first item.
- Fix place holder text in list view.
- Fix non-light collections.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-1519/remove-all-from-coll
branch
from
a4a8bf6 to
b74a980
Compare
- Add to the data classes a function to remove all includes and excludes. - Add to the UI a menu item to remove all includes and excludes. - Make the UI call the data when triggered. - Make menu item separators show up even as first item. - Fix place hodler text in list view. - Fix non-light collections. - Fix picking.
pierrebai-adsk
force-pushed
the
bailp/EMSUSD-1519/remove-all-from-coll
branch
from
b74a980 to
12cd85b
Compare
barbalt
reviewed
Dec 20, 2024
| EXPAND_PRIMS_MENU_OPTION = "Expand Prims" | ||
| EXPAND_PRIMS_PROPERTIES_MENU_OPTION = "Expand Prims and Properties" | ||
| EXPLICIT_ONLY_MENU_OPTION = "Explicit Only" | ||
| kIncludeExcludeLabel = "Include/Exclude" |
There was a problem hiding this comment.
minor: I know this is maya convention, but we probably would want to keep it capitalized for consistency in this case
There was a problem hiding this comment.
Ah, right I wrote these a few days ago, before the other review. We can change them afterward
barbalt
approved these changes
Dec 20, 2024
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.