Replace CodeAnalysis/AssignmentInCondition

Update references to account for the WPCS changes: WordPress/WordPress-Coding-Standards#2198
Automattic · Jun 22, 2023 · 78542ec · 78542ec
1 parent ef3d9f3
commit 78542ec
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/WordPress-VIP-Go/ruleset-test.inc b/WordPress-VIP-Go/ruleset-test.inc
@@ -153,7 +153,7 @@ url_to_postid( $url ); // Warning + Message.
 wpcom_vip_old_slug_redirect(); // Ok.
 wp_old_slug_redirect(); // Warning.
 
-// WordPress.CodeAnalysis.AssignmentInCondition.Found
+// Generic.CodeAnalysis.AssignmentInCondition.Found
 if ($a = 123) { // Warning.
 }
 

diff --git a/WordPress-VIP-Go/ruleset.xml b/WordPress-VIP-Go/ruleset.xml
@@ -184,7 +184,7 @@
 	<rule ref="Internal.LineEndings.Mixed">
 		<severity>1</severity>
 	</rule>
-	<rule ref="WordPress.CodeAnalysis.AssignmentInCondition.Found">
+	<rule ref="Generic.CodeAnalysis.AssignmentInCondition.Found">
 		<severity>1</severity>
 	</rule>
 	<rule ref="WordPress.PHP.DiscouragedPHPFunctions.urlencode_urlencode">

diff --git a/WordPressVIPMinimum/ruleset-test.inc b/WordPressVIPMinimum/ruleset-test.inc
@@ -76,7 +76,7 @@ $GLOBALS['wpdb'] = 'test'; // Error.
 if ( true == $true ) { // Warning.
 }
 
-// WordPress.CodeAnalysis.AssignmentInCondition
+// Generic.CodeAnalysis.AssignmentInCondition
 if ( $test = get_post( $post ) ) { // Warning.
 }
 

diff --git a/WordPressVIPMinimum/ruleset.xml b/WordPressVIPMinimum/ruleset.xml
@@ -29,7 +29,8 @@
 	<rule ref="Universal.Operators.StrictComparisons" phpcs-only="true">
 		<type>warning</type>
 	</rule>
-	<rule ref="WordPress.CodeAnalysis.AssignmentInCondition"/>
+	<rule ref="Generic.CodeAnalysis.AssignmentInCondition"/>
+	<rule ref="WordPress.CodeAnalysis.AssignmentInTernaryCondition"/>
 	<rule ref="WordPress.PHP.StrictInArray"/>
 	<rule ref="WordPress.PHP.DontExtract"/>
 	<rule ref="WordPress.WP.CronInterval">