Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WPCS: 3.0 merge_custom_array() #744

Closed
GaryJones opened this issue Jan 24, 2023 · 1 comment
Closed

WPCS: 3.0 merge_custom_array() #744

GaryJones opened this issue Jan 24, 2023 · 1 comment
Labels
Require: WPCS 3.0+ Type: Bug
Milestone
3.0.0

Comments

@GaryJones
Copy link
Contributor

Bug Description

The Sniff::merge_custom_array() function was moved to a new Helper class in WPCS: WordPress/WordPress-Coding-Standards#2157.

As per #734 (comment), it could still be used from WPCS, so the references (currently only 1) need updating when getting compatibility with 3.0.

Minimal Code Snippet

See

VIP-Coding-Standards/WordPressVIPMinimum/Sniffs/AbstractVariableRestrictionsSniff.php

Line 130 in 8953e4a

$this->excluded_groups = static::merge_custom_array( $this->exclude );

Environment

Use php -v and composer show to get versions.

Question Answer
PHP version N/A
PHP_CodeSniffer version N/A
VIPCS version dev-develop / 3.0.0
@GaryJones GaryJones mentioned this issue Jan 24, 2023
Closed
@jrfnl jrfnl added this to the 3.0.0 milestone Aug 26, 2023
@jrfnl
Copy link
Collaborator

jrfnl commented Aug 26, 2023

Closing as fixed via #779

@jrfnl jrfnl closed this as completed Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Require: WPCS 3.0+ Type: Bug
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@GaryJones @jrfnl