Move "property handling" related utilities to dedicated RulesetPropertyHelper
#2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtyHelper` The "property handling" related utilities are only used by a limited set of sniffs, so are better placed in a dedicated class. This commit moves the `merge_custom_array()` method to a new `WordPressCS\WordPress\Helpers\RulesetPropertyHelper` and starts using that class in the relevant sniffs. Note: the function has been moved without changes. Related to 1465
dingo-d
approved these changes
Dec 19, 2022
dingo-d
deleted the
feature/move-property-handling-method-to-helper-class
branch
GaryJones
added a commit
to Automattic/VIP-Coding-Standards
that referenced
this pull request
Dec 20, 2022
The previous `Sniff:merge_custom_array()` function was moved to a new class in WPCS: WordPress/WordPress-Coding-Standards#2157. While it is marked as non-public (only meant for WPCS directly), we only currently have a single usage, and making these change fixes a unit test error. We can reconsider if VIPCS needs its own copy before release.
GaryJones
added a commit
to Automattic/VIP-Coding-Standards
that referenced
this pull request
Dec 20, 2022
The previous `Sniff::merge_custom_array()` function was moved to a new Helper class in WPCS: WordPress/WordPress-Coding-Standards#2157. However, it is marked as non-public (only meant for WPCS directly), so copying into the VIPCS sniff is easiest for now.
GaryJones
added a commit
to Automattic/VIP-Coding-Standards
that referenced
this pull request
Jun 20, 2023
GaryJones
added a commit
to Automattic/VIP-Coding-Standards
that referenced
this pull request
Jun 22, 2023
GaryJones
added a commit
to Automattic/VIP-Coding-Standards
that referenced
this pull request
Jun 22, 2023
GaryJones
added a commit
to Automattic/VIP-Coding-Standards
that referenced
this pull request
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "property handling" related utilities are only used by a limited set of sniffs, so are better placed in a dedicated class.
This commit moves the
merge_custom_array()method to a newWordPressCS\WordPress\Helpers\RulesetPropertyHelperand starts using that class in the relevant sniffs.Note: the function has been moved without changes.
Related to #1465