WPCS 3.0: Fix coding standards of VIPCS sniffs #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
reviewed
Dec 30, 2022
There was a problem hiding this comment.
@GaryJones Reviewed just the commits which belong to this PR.
IMO...:
- Commit 1 and 2 (increment + reserved keywords) can/should be rebased on
developand pulled separately. These commits can be merged independently of PR WPCS 3.0: Composer updates #732 as they just apply some best practices (and anticipate that those will be checked for in WPCS 3.x). - By having those in a separate PR and merging it ahead of PR WPCS 3.0: Composer updates #732, PR WPCS 3.0: Composer updates #732 has a higher chance of getting a passing build.
- Commit 3 (ruleset change) should be combined with the commit changing the minimum WPCS version to
3.xin Composer as as soon as3.xbecomes the minimum, the ruleset becomes invalid without the change from this commit.
|
Updated to just the two suggested CS-related commits. No longer requires #732. |
jrfnl
approved these changes
Jan 25, 2023
|
As this has been merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once #732 has been merged, this can be rebased to just show coding standards changes.Update the VIPCS sniffs to fix the coding standards changes with WPCS 3.0.
CS: Use pre-increment over post-increment
Slightly better performance.
CS: Avoid reserved keyword for function param name
Using named parameters with a variable named
$stringis unfavourable.CS: Update WordPress-Extra exclusionsWordPress-Extra will no longer use theGeneric.Arrays.DisallowShortArraySyntaxrule, but does use the improvedUniversal.Arrays.DisallowShortArraySyntaxfrom PHPCSExtra instead, so whilst we have short array syntax being used in the VIPCS sniffs, let's continue to exclude the rule.