Update Compose to use BOM #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hichamboushaba
force-pushed
the
update-compose
branch
from
20cbc1e
to
097c1d9
Compare
ParaskP7
reviewed
Aug 26, 2024
There was a problem hiding this comment.
👋 @hichamboushaba !
I have reviewed this PR and it LGTM, thank YOU! 🌟
I just made a suggestion (💡) on Compose Compiler as I think it is better we declare and use that version too, no matter how temporarily. Let me know your thoughts.
ParaskP7
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Compose on the version catalog to use the latest BOM.
Since the compiler has been moved to be part of Kotlin itself, I didn't declare a version for it on the catalog, which means we'll keep using a literal version in FluxC temporarily, please share your thoughts on this.