Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish up the event for the block directory #31

Merged
merged 17 commits into from
Apr 23, 2020
Merged

Polish up the event for the block directory #31

merged 17 commits into from
Apr 23, 2020

Conversation

ajlende
Copy link
Contributor

@ajlende ajlende commented Feb 14, 2020

  • Rename jetpack to a8c
  • Update image replace flow
  • Add translation domain
  • Final layout tweaks
  • Add Event Block resources
    • Block directory block.json file
    • Tagline/Description copy
    • Plugin Assets

screenshot-1

Bundle: a8c-event.zip

@ajlende ajlende added the Enhancement New feature or request label Feb 14, 2020
@ajlende ajlende self-assigned this Feb 14, 2020
@ajlende ajlende force-pushed the polish/event branch 2 times, most recently from ce93ebe to a690925 Compare April 22, 2020 18:55
@ajlende ajlende marked this pull request as draft April 22, 2020 22:25
@ajlende
Copy link
Contributor Author

ajlende commented Apr 23, 2020

@jasmussen I've wrapped up all the changes that I wanted to make. Can you help me with some plugin assets for the directory?

@jasmussen
Copy link
Member

Hi Alex, lovely! If you feel this branch is solid, you can go ahead and merge it.

I'd like to make a few small visual changes -- a new G2 icon and other small things. I meant to get to that today, but due to unforeseen circumstance I have to jump to some toddler duty in a moment. So I'll probably get to some of this work tomorrow instead, at which point I'll also fix up the block directory assets.

@ajlende ajlende marked this pull request as ready for review April 23, 2020 12:11
@ajlende ajlende merged commit 0349111 into master Apr 23, 2020
@ajlende ajlende deleted the polish/event branch April 23, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants