Skip to content

Commit

Permalink
Odyssey Stats: Fix WP Footer Position (#28308)
Browse files Browse the repository at this point in the history
* [not verified] Odyssey Stats: remove inline CSS that limit the height of  #wpcom div

This was making the Odyssey Stats having some UI issues, like the footer that was wrongly positioned

* [not verified] changelog

* [not verified] Odyssey Stats: fix inline CSS that define the height of the #wpcom div

This was making the Odyssey Stats having some UI issues, like the footer that was wrongly positioned

* [not verified] Odyssey Stats: fix changelong significance

* Odyssey Stats: update version on package.json and class-main.php
  • Loading branch information
wilmersondasilva authored Jan 12, 2023
1 parent 6068e4a commit 0f40dac
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Fix Odyssey Stats footer position
2 changes: 1 addition & 1 deletion projects/packages/stats-admin/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"name": "@automattic/jetpack-stats-admin",
"version": "0.3.0",
"version": "0.3.1-alpha",
"description": "Stats Dashboard",
"homepage": "https://github.com/Automattic/jetpack/tree/HEAD/projects/packages/stats-admin/#readme",
"bugs": {
Expand Down
2 changes: 1 addition & 1 deletion projects/packages/stats-admin/src/class-dashboard.php
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ public function add_wp_admin_submenu() {
*/
public function render() {
?>
<div id="wpcom" class="jp-stats-dashboard" style="height: calc(100vh - 100px);">
<div id="wpcom" class="jp-stats-dashboard" style="min-height: calc(100vh - 100px);">
<div class="hide-if-js"><?php esc_html_e( 'Your Jetpack Stats dashboard requires JavaScript to function properly.', 'jetpack-stats-admin' ); ?></div>
<div class="hide-if-no-js" style="height: 100%">
<img
Expand Down
2 changes: 1 addition & 1 deletion projects/packages/stats-admin/src/class-main.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class Main {
/**
* Stats version.
*/
const VERSION = '0.3.0';
const VERSION = '0.3.1-alpha';

/**
* Singleton Main instance.
Expand Down

0 comments on commit 0f40dac

Please sign in to comment.