-
Notifications
You must be signed in to change notification settings - Fork 798
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Refactor subscriptions code so it can be used in Fusion (#11023)
Fixes a problem we've seen in developing the subscription block where we sometimes forget to make the equivalent upstream changes. #### Changes proposed in this Pull Request: * Moves the class Jetpack_Subscriptions_Widget into /modules/subscriptions/views.php * Moves the registration for the subscriptions block into /modules/subscriptions/views.php * /modules/subscriptions/views.php will be shared with wordpress.com #### Testing instructions: - Get this branch running locally or on jurassic.ninja - Ensure subscription widgets still function as usual - add a widget to the blog - add a subscription block to a post - try subscribing from the front end #### Proposed changelog entry for your changes: No changelog needed
- Loading branch information
1 parent
f3b4986
commit 1c3ce55
Showing
3 changed files
with
740 additions
and
357 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
## Assets for Subscriptions | ||
|
||
### subscriptions.css | ||
|
||
CSS required to render the subscription widget | ||
|
||
### views.php | ||
|
||
This file handles the registration of various subscriptions | ||
views, i.e. a widget and a block for the post editor. | ||
|
||
This file is shared with wordpress.com |
Oops, something went wrong.