Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg: Publicize: Hide or Disable Settings for Contributor #10910

Closed
alisterscott opened this issue Dec 7, 2018 · 5 comments · Fixed by #10912
Closed

Gutenberg: Publicize: Hide or Disable Settings for Contributor #10910

alisterscott opened this issue Dec 7, 2018 · 5 comments · Fixed by #10912
Assignees
@tyxla
Labels
[Feature] Publicize Now Jetpack Social, auto-sharing [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Milestone
6.9

Comments

@alisterscott
Copy link
Contributor

Steps to reproduce

  1. Starting at URL: As a contributor user open https://wpcalypso.wordpress.com/block-editor/post/
  2. Click Jetpack icon

What I expected

Since contributors can't publish - I don't think we should show them Publicize settings at all

What happened instead

Displays publicize settings and link to add new connection which links to a page where user doesn't have permissions so sees an error

Browser / OS version

Chrome 70 on macOS

Screenshot / Video

hide publicize contributor

Context / Source

Manual testing
@alisterscott
Copy link
Contributor Author

In the classic calypso editor these settings are displayed but disabled:

screen shot 2018-12-07 at 3 32 41 pm

@alisterscott alisterscott changed the title Gutenberg: Publicize: Hide Settings for Contributor Gutenberg: Publicize: Hide or Disable Settings for Contributor Dec 7, 2018
@vindl
Copy link
Member

vindl commented Dec 10, 2018

Removing this from Calypso Gutenberg Integration project for the same reasons stated in https://github.com/Automattic/wp-calypso/issues/29212#issuecomment-445750443.

@tyxla
Copy link
Member

tyxla commented Dec 10, 2018

It seems we're not doing the necessary capability checks before displaying the Publicize UI to users. This is something that we should handle at block availability level, so I'm moving this issue to the Jetpack repo.

@tyxla tyxla transferred this issue from Automattic/wp-calypso Dec 10, 2018
@tyxla tyxla added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Publicize Now Jetpack Social, auto-sharing [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Dec 10, 2018
@tyxla
Copy link
Member

tyxla commented Dec 10, 2018

Should be quick to fix, I'm on it.

@tyxla tyxla self-assigned this Dec 10, 2018
@tyxla tyxla mentioned this issue Dec 10, 2018
Merged
@tyxla
Copy link
Member

tyxla commented Dec 10, 2018

#10912 addresses that.

@tyxla tyxla added this to the 6.9 milestone Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tyxla tyxla

Labels
[Feature] Publicize Now Jetpack Social, auto-sharing [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
6.9
Development

Successfully merging a pull request may close this issue.

Gutenberg: Check for Publicize capabilities at registration Automattic/jetpack
4 participants
@kraftbj @alisterscott @vindl @tyxla