Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caption links not working on galleries in Gutenberg #10997

Closed
Robertght opened this issue Dec 18, 2018 · 0 comments
Closed

Caption links not working on galleries in Gutenberg #10997

Robertght opened this issue Dec 18, 2018 · 0 comments
Assignees
@jeherve
Labels
[Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Type] Bug When a feature is broken and / or not performing as intended
Milestone
6.9

Comments

@Robertght
Copy link

Steps to reproduce the issue

  1. Create a regular gallery via Gutenberg and link the captions.
  2. Publish them and try to click on the link.
  3. It will open the carousel instead of the link.
  4. Repeat the same process with a single image, not a gallery - it will open the link of the caption.

What I expected

To open the link and not the carousel.

What happened instead

It opened the carousel.

A current workaround is to turn off the Carousel option via Settings-> Media, but that will not disable it for all the galleries.

Cases: #1642357-zen, #1642865-zen
@Robertght Robertght added [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Dec 18, 2018
@jeherve jeherve added the [Type] Bug When a feature is broken and / or not performing as intended label Dec 18, 2018
@jeherve jeherve added this to the 6.9 milestone Dec 18, 2018
@jeherve jeherve self-assigned this Dec 20, 2018
jeherve added a commit that referenced this issue Dec 20, 2018
@jeherve
Carousel: do not open modal when clicking on a link in a caption
bc87e82 
Fixes #10997

The new Core gallery block introduces a different markup for captions.
This PR makes sure that when clicking on a link in a caption inside a core gallery, you get redirected
to that link, instead of having the Carousel modal open.
@jeherve jeherve mentioned this issue Dec 20, 2018
Merged
jeherve added a commit that referenced this issue Dec 21, 2018
@jeherve
Carousel: do not open modal when clicking on a link in a caption (#11024
cc14b51 
)

* Carousel: do not open modal when clicking on a link in a caption

Fixes #10997

The new Core gallery block introduces a different markup for captions.
This PR makes sure that when clicking on a link in a caption inside a core gallery, you get redirected
to that link, instead of having the Carousel modal open.

* Bump js file version number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeherve jeherve

Labels
[Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
6.9
Development

No branches or pull requests
2 participants
@jeherve @Robertght