Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carousel: 400 errors on Ajax requests to get comments for each image #11148

Closed
jeherve opened this issue Jan 16, 2019 · 0 comments · Fixed by #11195
Closed

Carousel: 400 errors on Ajax requests to get comments for each image #11148

jeherve opened this issue Jan 16, 2019 · 0 comments · Fixed by #11195
Assignees
@jeherve
Labels
[Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Pri] High [Type] Bug When a feature is broken and / or not performing as intended
Milestone
7.0

Comments

@jeherve
Copy link
Member

jeherve commented Jan 16, 2019 •
edited
Loading

Steps to reproduce the issue

  1. Start on a post with a gallery, Carousel active, and 6.9 installed. The problem did not exist in 6.8.1. The gallery can be a classic one, or a gallery block.
  2. Click on the gallery to open the carousel modal.
  3. As you move through the images in the gallery, you will notice 400 errors on all the Ajax calls that are made to retrieve comments for each image.
wp-admin/admin-ajax.php?action=get_attachment_comments&nonce=dc6aed47f7&id=13568&offset=0
Status Code: 400 Bad Request
Response: 0

The problem appears to be caused by #10945.
https://github.com/Automattic/jetpack/pull/10945/files#diff-3cfca2b828797ec0937ace907f546d80R32
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Pri] High labels Jan 16, 2019
@jeherve jeherve added this to the 7.0 milestone Jan 16, 2019
This was referenced Jan 21, 2019
Closed
Merged
@jeherve jeherve self-assigned this Jan 25, 2019
@jeherve jeherve mentioned this issue Jan 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeherve jeherve

Labels
[Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Pri] High [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
7.0
Development

Successfully merging a pull request may close this issue.

AMP: move checks for AMP requests later, inside modules. Automattic/jetpack
1 participant
@jeherve