Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel: Master kill switch for comments #3101

Closed
kraftbj opened this issue Dec 3, 2015 · 10 comments
Closed

Carousel: Master kill switch for comments #3101

kraftbj opened this issue Dec 3, 2015 · 10 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. Good For Community [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@kraftbj
Copy link
Contributor

kraftbj commented Dec 3, 2015

The Carousel window allows comments, that are associated with the attachment post, based on each media item's Discussion settings.

Individual attachments will have comments enabled based on Core's generic option for opening comments on new articles. To disable for an individual media item, users need to visit the Media Library, choose a particular image, click the "Edit More Details" link, (enable the Discussions metabox via Screen Options), uncheck Comments and Save.

Idea: Should we add an option that will kill the comment form on all carousel modals? Or is there a better way to handle this ourselves? Or a Core problem?

ref: 2443324-t

@kraftbj kraftbj added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. labels Dec 3, 2015
@kraftbj kraftbj added this to the Community milestone Dec 3, 2015
@jeherve
Copy link
Member

jeherve commented Dec 3, 2015

@jeherve
Copy link
Member

jeherve commented Jan 13, 2017

Closing this for now because of the lack of activity on this. We can always reopen in the future if needed.

@htdat
Copy link
Member

htdat commented Jan 28, 2019

Reopening this as this user is requesting it 1744463-zen:

I would like to encourage you to build in a switch to turn off the comment
function below the carousel (Gallerie).
There are so many reasons against this comment function.

  1. It dosn't work in the most cases.
  2. Ugly and disturbing
  3. Pics would be more centered.
  4. I don't want any comment to my pics :-)

I have a lot of friends and colleagues using Jetpack and nearly each of them
using the carousel is complaining about the comment function.
I know 4 persons not using Jetpack at all anymore because of problems with the
some other 'lighboxes' and they don't want to have also these comment function.

@htdat htdat reopened this Jan 28, 2019
@jeherve jeherve added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 28, 2019
@jeherve
Copy link
Member

jeherve commented Jan 28, 2019

It dosn't work in the most cases.

I assume this is the issue reported in #11148; it will be fixed in the next release.

Ugly and disturbing

It would be good to find out more here; the comment feature is not displayed in the modal by default, you have to scroll down to see it. Are they referring to the same comment feature?

Pics would be more centered.

The comment form does not have an impact on the alignment of the images in the Carousel modal.

Could you ask them for more details about this?

@htdat
Copy link
Member

htdat commented Jan 29, 2019

Thanks Jeremy. I am asking this user in 1744463-zen.

@tbradsha
Copy link
Contributor

Requested here: 11166400-hc.

@stale
Copy link

stale bot commented Sep 8, 2019

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Sep 8, 2019
@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" label Sep 8, 2019
@stale stale bot removed the [Status] Stale label Sep 8, 2019
@zdenys
Copy link
Contributor

zdenys commented Nov 29, 2019

Another where it would have been helpful to avoid the CSS solution 16997128-hc

@stale
Copy link

stale bot commented May 30, 2020

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label May 30, 2020
@jeherve
Copy link
Member

jeherve commented Feb 17, 2021

This was implemented in #15436.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. Good For Community [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

7 participants