Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Masterbar: handle Hamburger menu when in block editor on mobile #12320

Closed
jeherve opened this issue May 9, 2019 · 6 comments · Fixed by #12337
Closed

Masterbar: handle Hamburger menu when in block editor on mobile #12320

jeherve opened this issue May 9, 2019 · 6 comments · Fixed by #12337
Assignees
@scottsweb
Labels
[Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Pri] Normal [Status] Needs Design [Type] Bug When a feature is broken and / or not performing as intended

Comments

@jeherve
Copy link
Member

jeherve commented May 9, 2019

Steps to reproduce the issue

  1. Activate the WordPress.com toolbar feature.
  2. On mobile, go to Posts > Add New
  3. You'll see the hamburger getting in the way of content:

image
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Status] Needs Design labels May 9, 2019
@jeherve jeherve mentioned this issue May 9, 2019
Merged
@simison
Copy link
Member

simison commented May 9, 2019

Something funky going on here with block editor sidebar open:
image

@jeherve
Copy link
Member Author

jeherve commented May 9, 2019

For reference, here is how the Core toolbar handles it:

image

@scottsweb scottsweb mentioned this issue May 10, 2019
Merged
@scottsweb scottsweb self-assigned this May 10, 2019
@jeherve jeherve added this to the 7.4 milestone May 16, 2019
@jeherve jeherve mentioned this issue Mar 25, 2020
Closed
@jeherve
Copy link
Member Author

jeherve commented Mar 25, 2020

Reopening, as this is happening again right now (see Automattic/wp-calypso#40426 )

@jeherve jeherve reopened this Mar 25, 2020
@jeherve jeherve removed this from the 7.4 milestone Mar 25, 2020
@sirreal
Copy link
Member

sirreal commented May 14, 2020

Brought this up in some masterbar-related discussions: pbAPfg-3G-p2#comment-988

@lakellie
Copy link

Noting here we have a user in #2806214-zen who should be followed up with if/when this is resolved.

@jeherve
Copy link
Member Author

jeherve commented Jun 24, 2020

I have not tested this myself, but this should now be fixed as of Automattic/wp-calypso#40426 (comment)

@jeherve jeherve closed this as completed Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scottsweb scottsweb

Labels
[Feature] Masterbar WordPress.com Toolbar and Dashboard customizations [Pri] Normal [Status] Needs Design [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove admin menu toggle in new post screen Automattic/jetpack
5 participants
@simison @scottsweb @jeherve @sirreal @lakellie