-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Masterbar: display a Hamburger menu on mobile #12299
Conversation
Follow-up from #11766 This Hamburger menu is necessary so folks can access the wp-admin navigation on mobile.
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: June 3, 2019. |
We use wp_is_mobile() here because our own jetpack_is_mobile() would return true even on tabletss, where the wp-admin navigation is toggled: https://github.com/WordPress/WordPress/blob/f5cab6780f67195bf717eb33f2a3661ef5f95242/wp-admin/js/common.js#L512
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WFM!
That hamburger is hidden via CSS on non-mobile views. Relying only on CSS allows us to cover all edge cases, like folks on desktop but with a very small viewport that would trigger the wp-admin navigation menu to be toggled. Related discussion: p1557322468103000-slack-jetpack-plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 even better!
* Masterbar: display a Hamburger menu on mobile Follow-up from #11766 This Hamburger menu is necessary so folks can access the wp-admin navigation on mobile. * Masterbar: only display the Hamburger menu on mobile We use wp_is_mobile() here because our own jetpack_is_mobile() would return true even on tabletss, where the wp-admin navigation is toggled: https://github.com/WordPress/WordPress/blob/f5cab6780f67195bf717eb33f2a3661ef5f95242/wp-admin/js/common.js#L512 * Always add the hamburger menu toggle. That hamburger is hidden via CSS on non-mobile views. Relying only on CSS allows us to cover all edge cases, like folks on desktop but with a very small viewport that would trigger the wp-admin navigation menu to be toggled. Related discussion: p1557322468103000-slack-jetpack-plugin * Masterbar: rely on core function to add toggle.
* Masterbar: display a Hamburger menu on mobile Follow-up from #11766 This Hamburger menu is necessary so folks can access the wp-admin navigation on mobile. * Masterbar: only display the Hamburger menu on mobile We use wp_is_mobile() here because our own jetpack_is_mobile() would return true even on tabletss, where the wp-admin navigation is toggled: https://github.com/WordPress/WordPress/blob/f5cab6780f67195bf717eb33f2a3661ef5f95242/wp-admin/js/common.js#L512 * Always add the hamburger menu toggle. That hamburger is hidden via CSS on non-mobile views. Relying only on CSS allows us to cover all edge cases, like folks on desktop but with a very small viewport that would trigger the wp-admin navigation menu to be toggled. Related discussion: p1557322468103000-slack-jetpack-plugin * Masterbar: rely on core function to add toggle.
Reported here: 2016105-zd |
Yep, same in Jetpack. This isn't new with this PR though, it used to be like that with the Masterbar as well. Took note of it in #12320 |
Follow-up from #11766
Changes proposed in this Pull Request:
This Hamburger menu is necessary so folks can access the wp-admin navigation on mobile.
Without it, when on mobile, one has no way to go from one wp-admin page to another:
Testing instructions:
/wp-admin/
Proposed changelog entry for your changes: