Masterbar: display a Hamburger menu on mobile #12299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up from #11766 This Hamburger menu is necessary so folks can access the wp-admin navigation on mobile.
jeherve
added
[Type] Bug
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: June 3, 2019. |
We use wp_is_mobile() here because our own jetpack_is_mobile() would return true even on tabletss, where the wp-admin navigation is toggled: https://github.com/WordPress/WordPress/blob/f5cab6780f67195bf717eb33f2a3661ef5f95242/wp-admin/js/common.js#L512
That hamburger is hidden via CSS on non-mobile views. Relying only on CSS allows us to cover all edge cases, like folks on desktop but with a very small viewport that would trigger the wp-admin navigation menu to be toggled. Related discussion: p1557322468103000-slack-jetpack-plugin
jeherve
removed
the
[Status] Needs Review
jeherve
added a commit
that referenced
this pull request
May 8, 2019
* Masterbar: display a Hamburger menu on mobile Follow-up from #11766 This Hamburger menu is necessary so folks can access the wp-admin navigation on mobile. * Masterbar: only display the Hamburger menu on mobile We use wp_is_mobile() here because our own jetpack_is_mobile() would return true even on tabletss, where the wp-admin navigation is toggled: https://github.com/WordPress/WordPress/blob/f5cab6780f67195bf717eb33f2a3661ef5f95242/wp-admin/js/common.js#L512 * Always add the hamburger menu toggle. That hamburger is hidden via CSS on non-mobile views. Relying only on CSS allows us to cover all edge cases, like folks on desktop but with a very small viewport that would trigger the wp-admin navigation menu to be toggled. Related discussion: p1557322468103000-slack-jetpack-plugin * Masterbar: rely on core function to add toggle.
jeherve
added a commit
that referenced
this pull request
May 8, 2019
* Masterbar: display a Hamburger menu on mobile Follow-up from #11766 This Hamburger menu is necessary so folks can access the wp-admin navigation on mobile. * Masterbar: only display the Hamburger menu on mobile We use wp_is_mobile() here because our own jetpack_is_mobile() would return true even on tabletss, where the wp-admin navigation is toggled: https://github.com/WordPress/WordPress/blob/f5cab6780f67195bf717eb33f2a3661ef5f95242/wp-admin/js/common.js#L512 * Always add the hamburger menu toggle. That hamburger is hidden via CSS on non-mobile views. Relying only on CSS allows us to cover all edge cases, like folks on desktop but with a very small viewport that would trigger the wp-admin navigation menu to be toggled. Related discussion: p1557322468103000-slack-jetpack-plugin * Masterbar: rely on core function to add toggle.
|
Reported here: 2016105-zd |
matticbot
added
the
Customer Report
|
on wpcom wp-admin, Gutenberg's post-publish view looks like this now:
Editor itself:
|
|
Yep, same in Jetpack. This isn't new with this PR though, it used to be like that with the Masterbar as well. Took note of it in #12320 |
kraftbj
added a commit
that referenced
this pull request
May 23, 2019
kraftbj
added a commit
that referenced
this pull request
May 23, 2019
kraftbj
added a commit
that referenced
this pull request
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #11766
Changes proposed in this Pull Request:
This Hamburger menu is necessary so folks can access the wp-admin navigation on mobile.
Without it, when on mobile, one has no way to go from one wp-admin page to another:
Testing instructions:
/wp-admin/Proposed changelog entry for your changes: