Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiled Gallery: Photon strips color profile information #13561

Closed
jordesign opened this issue Sep 27, 2019 · 5 comments
Closed

Tiled Gallery: Photon strips color profile information #13561

jordesign opened this issue Sep 27, 2019 · 5 comments
Assignees
Labels
[Block] Tiled Gallery Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Photon aka "Image CDN". Feature developed in the Image CDN package and shipped in multiple plugins [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Type] Bug When a feature is broken and / or not performing as intended

Comments

@jordesign
Copy link
Contributor

It appears that when images are inserted into a Tiled Gallery they include the string ?strip=all in the Photon URL. This strips EXIF data and color profile information (as documented here).

The result is that when an image that has been saved with a color profile other than sRGB is inserted - the color will shift in a way the user doesn't expect. When the thumbnail is clicked - it loads the image without the color profile stripped which makes it even more obvious

By comparison - the native 'Gallery' and CoBlocks 'Masonry' gallery insert the thumbnails without stripping the color profile. The behavior should be consistent across the three gallery types.

Steps to reproduce the issue

  1. Start a new Page or Post
  2. Insert a 'Tiled Gallery' block
  3. Include an image that has a color profile saved as part of the file (here's one you can test )
  4. Publish post/page

What I expected

The image to be displayed on the page as it shows on my local machine, in the media library, and when loaded directly in the browser

What happened instead

The image shows with the colors shifted to different tones

Testing/Example

You can review this post which contains a default Gallery, Tiled Gallery and Masonry Gallery for comparison: https://lamontjordan.blog/2019/09/25/testing-a-gallery/

Screenshots

Result of color shift

@jordesign jordesign added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Photon aka "Image CDN". Feature developed in the Image CDN package and shipped in multiple plugins [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. labels Sep 27, 2019
@jeherve jeherve added [Block] Tiled Gallery [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Sep 27, 2019
@jeherve
Copy link
Member

jeherve commented Sep 27, 2019

cc @sirreal; do you remember why we had needed that parameter in #12061?

@sirreal
Copy link
Member

sirreal commented Sep 27, 2019

do you remember why we had needed that parameter in #12061?

It looks like an oversight and we should have used ?strip=info or just omitted it.

@kristarella
Copy link

We have another report of this in 2413433-zen

If it's not needed we would love for it to be removed :)

@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" label Oct 11, 2019
@jordesign jordesign self-assigned this Oct 12, 2019
@stale
Copy link

stale bot commented Apr 9, 2020

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Apr 9, 2020
@jordesign
Copy link
Contributor Author

Closing as this is reslved in #13735

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Tiled Gallery Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Photon aka "Image CDN". Feature developed in the Image CDN package and shipped in multiple plugins [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

6 participants