Tiled Gallery: Ensure Photon strips only 'info', not 'all' when inserting SrcSet

[jordesign]

Changes proposed in this Pull Request:

This ensures that when SrcSets are generated by the Tiled Gallery they only direct Photon to strip 'Info' instead of 'all' (which removes color profile information).

This addresses issue #13561

Is this a new feature or does it add/remove features to an existing part of Jetpack?

• This is a bug fix

Testing instructions:

• Insert a Tiled Gallery block into a post or page.
• Upload an image which contains a Color Profile saved within the file. You can use this image to test.
• Publish the post/page
• The image within the gallery should appear with the same color brightness/values as you see when loading the original image directly in the browser.

Before (right image has color profile):

After (right image has color profile):

Proposed changelog entry for your changes:

• Color Profile information is retained for images in Tiled Galleries

[matticbot]

Caution: This PR has changes that must be merged to WordPress.com
Hello jordesign! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D33961-code before merging this PR. Thank you!

[jordesign]

This is my first PR for Jetpack - but figured as I reported the Issue I should see about fixing it. Totally open to all and any feedback 👍

[jetpackbot]

	Warnings
⚠️	The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 27574f8

[sirreal]

Thanks @jordesign! I suspect there will be an issue with block invalidation with this change. Have you tested creating a Tiled Gallery block without this change, then loading the same post in the block editor with this change? The block will likely be invalidated because save produces different output.

Here's some information about how to deal with that issue if it arises: https://developer.wordpress.org/block-editor/developers/block-api/block-deprecation/

[jordesign]

Thanks for mentioning that @sirreal - I wouldn't have thought of it at all.

I've tested that with the branch - and it doesn't appear to be an issue. When inserting the gallery with the Maater branch (and strip="all") and switching to the PR branch (strip="info") - the block still loads in both the front end and the editor. No invalid block 👍

[jeherve]

This seems to work well for me. Leaving it for @sirreal to give a final approval since he worked on the srcset implementation.

I suspect there will be an issue with block invalidation with this change.

That wasn't an issue in my tests. Could it be because the srcset attribute is not saved in the block html?

[sirreal]

• I only see the issue on Simple (WordPress.com) sites, not on Jetpack sites. I wonder if we're observing a difference in Photon implementation 😕
• I have been unable to reproduce the issue with a Jetpack site, so it's tricky to verify whether this is a fix 🙂
• I can reproduce the issue on Simple sites, but I'm having issues with my sandbox and haven't been able to test the patch.
• I do see the expected changes without block invalidation (👍) when I apply this patch to my Jetpack site, so that aspect looks good.

[jeherve]

I can reproduce the issue on Simple sites, but I'm having issues with my sandbox and haven't been able to test the patch.

The patch seems to work on my end on Simple sites. I've committed the change there as well.