Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photon: Test handling of big images #13701

Open
kraftbj opened this issue Oct 10, 2019 · 4 comments
Open

Photon: Test handling of big images #13701

kraftbj opened this issue Oct 10, 2019 · 4 comments
Assignees
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Photon aka "Image CDN". Feature developed in the Image CDN package and shipped in multiple plugins [Status] Stale [Type] Bug When a feature is broken and / or not performing as intended

Comments

@kraftbj
Copy link
Contributor

kraftbj commented Oct 10, 2019

Flyby to investigate the handling of big images in 5.3: https://make.wordpress.org/core/2019/10/09/introducing-handling-of-big-images-in-wordpress-5-3/

Make sure we are compatible (should be I reckon) and see if there are any optimizations we can add for those on 5.3.

Master issue: #13597

@kraftbj kraftbj added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Photon aka "Image CDN". Feature developed in the Image CDN package and shipped in multiple plugins labels Oct 10, 2019
@kraftbj kraftbj added this to the 7.9 milestone Oct 10, 2019
@kraftbj kraftbj self-assigned this Oct 10, 2019
@kraftbj
Copy link
Contributor Author

kraftbj commented Oct 14, 2019

Some discussion at p9dueE-13w-p2 . The "full" image would change with 5.3 that we pull since the filename format is different than most resized images. Need to decide which way to go.

@jeherve jeherve modified the milestones: 7.9, 8.0 Oct 24, 2019
@jeherve jeherve modified the milestones: 8.0, 8.1 Nov 22, 2019
@jeherve jeherve removed this from the 8.1 milestone Dec 20, 2019
@kraftbj kraftbj changed the title Photon: Confirm compat with 5.3 Photon: Test handling of big images Jan 28, 2020
@kraftbj
Copy link
Contributor Author

kraftbj commented Jan 28, 2020

Related in 2659499-zen, we should examine whether the usage of the theme's content width (specifically the default of 1000px when none is set) is still needed in today's Gutenberg full-width era.

@matticbot matticbot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" label Jan 28, 2020
@jeherve
Copy link
Member

jeherve commented Jan 28, 2020

we should examine whether the usage of the theme's content width (specifically the default of 1000px when none is set) is still needed in today's Gutenberg full-width era.

Related: #4175

@stale
Copy link

stale bot commented Jul 26, 2020

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report" [Feature] Photon aka "Image CDN". Feature developed in the Image CDN package and shipped in multiple plugins [Status] Stale [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants