Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status Package: Add additional checks #13711

Open
kraftbj opened this issue Oct 10, 2019 · 1 comment
Open

Status Package: Add additional checks #13711

kraftbj opened this issue Oct 10, 2019 · 1 comment
Labels
[Package] Status [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@kraftbj
Copy link
Contributor

kraftbj commented Oct 10, 2019

In working on #13698, our Status package has development mode, but does not check if a Jetpack connection is active, if we have confirmed the TOS, etc. We should add more of these checks over to help when non-Jetpack plugins use some of our packages and tools.
@kraftbj kraftbj added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Package] Status labels Oct 10, 2019
jeherve added a commit that referenced this issue Oct 11, 2019
@jeherve
Simplify approach to one single function
0894993 
- keep that function in a file that is already synchronized with WordPress.com
- include both wpcom and Jetpack tracking approaches in that function.
- remove the dev mode check since this will be addressed in #13711
@kraftbj kraftbj mentioned this issue Oct 14, 2019
Merged
jeherve added a commit that referenced this issue Oct 29, 2019
@scruffian @jeherve
Add tracking for the contact form block (#13688)
c2dd31d 
* Add tracking for the contact form

* Add file

* Make it possible to track contact form submissions only coming from Gutenberg blocks

* update event name

* escape data sent to tracks

* add a jetpack prefix to the tracks event function

* add new file to the phpcs whitelist

* fix undefined index error

* fix undefined index error

* dont send tracks events in development mode

* use a different tracks implementation on wpcom

* move wpcom tracking to a different file

* Simplify approach to one single function

- keep that function in a file that is already synchronized with WordPress.com
- include both wpcom and Jetpack tracking approaches in that function.
- remove the dev mode check since this will be addressed in #13711

* Send blog ID in recorded event when available

* Feedback ID can include letters as well. Let's not sanitize as int

* Specify a user when submission is anonymous

* Use a different prefix for WordPress.com and Jetpack

If we don't do that we can't separate the 2 when looking at the data later on.

* Add missing comment *

* Switch to using record_user_event

See https://github.com/Automattic/jetpack/pull/13688/files#r339803539


Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
@stale
Copy link

stale bot commented Apr 7, 2020

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Package] Status [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kraftbj @anomiex