Eventbrite block: Improve default UI #14462
Assignees
Labels
[Block] Eventbrite
[Type] Enhancement
Changes to an existing feature — removing, adding, or changing parts of it
Milestone
Comments
Copons
added
[Type] Enhancement
Merged
Was resolved by #14510 |
apeatling
added a commit
that referenced
this issue
Feb 5, 2020
… can edit if needed. Partially fixes #14462
This was referenced Feb 5, 2020
jeherve
pushed a commit
that referenced
this issue
Feb 10, 2020
* Eventbrite Block: Add a default modal button label text that the user can edit if needed. Partially fixes #14462 * Eventbrite Block: Use the default option for the text attribute to instead use Gutenbergs default way of handling default values. Props @Copons. * Eventbrite Block: Remove the default modal button text constant since we only need to use that in a single place.
jeherve
pushed a commit
that referenced
this issue
Feb 10, 2020
…4585) * Eventbrite Block: Add a default modal button label text that the user can edit if needed. Partially fixes #14462 * Eventbrite Block: Use the default option for the text attribute to instead use Gutenbergs default way of handling default values. Props @Copons. * Eventbrite Block: Remove the default modal button text constant since we only need to use that in a single place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue tracks two different enhancements:
Provide a default text (e.g. "Register") for the block's Button mode.Eventbrite Block: Add a default modal button label #14585Right now, a missing text for the button could go unnoticed in the editor where it has a placeholder text, but looks weird on the front end.
Return a link to the event on the front end.Eventbrite block: add link to saved HTML #14510When reading the post in contexts that don't have the Eventbrite block (mail, feeds, with Jetpack deactivated) the block would still show something useful.
Add default styling to the Embed button in the placeholder so that it has a border like all other blocks.Eventbrite Block: Add isDefault to the Embed button #14588The text was updated successfully, but these errors were encountered: