Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calypso Build: production build now outputs .LICENSE files #14731

Closed
jeherve opened this issue Feb 19, 2020 · 2 comments
Closed

Calypso Build: production build now outputs .LICENSE files #14731

jeherve opened this issue Feb 19, 2020 · 2 comments
Assignees
@kraftbj @jeherve
Labels
Build [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Milestone
8.4

Comments

@jeherve
Copy link
Member

jeherve commented Feb 19, 2020

For the past few releases (I think it may have started after we updated to calypso-build 6 in #14194), I’ve noticed that we are now generating .LICENSE files next to bundles, i.e. editor.js now has editor.js.LICENSE too.

To reproduce, run NODE_ENV=production yarn build-extensions and watch _inc/blocks for .LICENSE files.

I wonder if it may originate from Automattic/wp-calypso#37412

We may have to add additional build options here:
https://github.com/Automattic/wp-calypso/blob/master/packages/calypso-build/webpack/minify.js#L39
https://github.com/webpack-contrib/terser-webpack-plugin#extractcomment

Internal discussion: p1582131921461500-slack-team-calypso
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Pri] Normal [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Build labels Feb 19, 2020
@tyxla tyxla mentioned this issue Feb 20, 2020
Merged
@renovate renovate bot mentioned this issue Mar 4, 2020
Merged
1 task
@jeherve jeherve added this to the 8.4 milestone Mar 4, 2020
@kraftbj kraftbj self-assigned this Mar 4, 2020
@kraftbj
Copy link
Contributor

kraftbj commented Mar 4, 2020

Assigning myself for the Asana sync since it only does Crew folks for now.

@jeherve jeherve self-assigned this Mar 23, 2020
@jeherve
Copy link
Member Author

jeherve commented Mar 25, 2020

Fixed in #14849

@jeherve jeherve closed this as completed Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kraftbj kraftbj

@jeherve jeherve

Labels
Build [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
8.4
Development

No branches or pull requests
2 participants
@kraftbj @jeherve