Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency @automattic/calypso-build to v6.0.0 #14194

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Update dependency @automattic/calypso-build to v6.0.0 #14194

merged 1 commit into from
Jan 20, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Dec 7, 2019 •
edited by jeherve
Loading

Fixes #14273

This PR contains the following updates:

Package Type Update Change
@automattic/calypso-build dependencies minor 5.0.1 -> 5.1.0

Release Notes

Automattic/wp-calypso

v5.1.0

Compare Source

Renovate configuration

📅 Schedule: "every weekend" in timezone UTC.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested a review from a team December 7, 2019 00:05
@renovate renovate bot added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial labels Dec 7, 2019
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello renovate[bot]! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D36410-code before merging this PR. Thank you!

@jetpackbot
Copy link

jetpackbot commented Dec 7, 2019 •
edited
Loading

Warnings
⚠️ "Testing instructions" are missing for this PR. Please add some
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against db240fc

@renovate renovate bot force-pushed the renovate/automattic-calypso-build-5.x branch from c051f08 to c630704 Compare December 14, 2019 00:02
@matticbot
Copy link
Contributor

renovate[bot], Your synced wpcom patch D36410-code has been updated.

@renovate renovate bot force-pushed the renovate/automattic-calypso-build-5.x branch from c630704 to 3a98c6e Compare January 4, 2020 00:03
@matticbot
Copy link
Contributor

renovate[bot], Your synced wpcom patch D36410-code has been updated.

@glendaviesnz glendaviesnz mentioned this pull request Jan 10, 2020
Closed
@simison simison mentioned this pull request Jan 17, 2020
Closed
@jeherve
Copy link
Member

jeherve commented Jan 20, 2020 •
edited
Loading

I wanted to update this PR to 6.0.0, but I can't build Jetpack when I do so:

Message:
    Module build failed (from ./node_modules/@automattic/calypso-build/node_modules/thread-loader/dist/cjs.js):
Thread Loader (Worker 0)
[BABEL] wp-content/plugins/jetpack/node_modules/@automattic/format-currency/node_modules/debug/src/browser.js: Cannot find module '@babel/plugin-transform-runtime' from 'wp-content/plugins/jetpack'

@jsnajdr Do you know why this would be happening?

@jsnajdr
Copy link
Member

jsnajdr commented Jan 20, 2020

@jeherve @simison I'm here and looking! 🔎

@jsnajdr jsnajdr force-pushed the renovate/automattic-calypso-build-5.x branch from 3a98c6e to db240fc Compare January 20, 2020 13:57
@matticbot
Copy link
Contributor

renovate[bot], Your synced wpcom patch D36410-code has been updated.

@jsnajdr jsnajdr changed the title Update dependency @automattic/calypso-build to v5.1.0 Update dependency @automattic/calypso-build to v6.0.0 Jan 20, 2020
@jsnajdr
Copy link
Member

jsnajdr commented Jan 20, 2020

In addition to updating @automattic/calypso-build to 6.0.0, I also update the @babel/core, @babel/preset-env and webpack dependencies to the same version as used by calypso-build.

I also removed the file-loader dependency. It's used only inside the calypso-build scripts and required by that package. As Jetpack build scripts don't use it directly, the depedency doesn't need to be specified in Jetpack's package.json.

I ran yarn build, yarn build-extensions and yarn build-search and verified that the compiled JS bundles contain debug source code, correctly transpiled (e.g., const replaced by var).

@jeherve jeherve added the Build label Jan 20, 2020
@jeherve jeherve added this to the 8.2 milestone Jan 20, 2020
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jan 20, 2020
jeherve
jeherve approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to test well for me in Chrome and in IE11. Nice work! Merging.

@jeherve jeherve merged commit 5fb3587 into master Jan 20, 2020
@jeherve jeherve deleted the renovate/automattic-calypso-build-5.x branch January 20, 2020 17:11
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jan 20, 2020
jeherve added a commit that referenced this pull request Jan 27, 2020
@jeherve
Changelog: add #14194
00de59b
jeherve added a commit that referenced this pull request Jan 28, 2020
@jeherve
Changelog: 8.2 release (#14332)
0589a49 
* [not verified] Remove empty readme section

* Initial changelog for 8.2

* Changelog: add #14220

* Changelog: add #14252

* Changelog: add #14291

* Changelog: add #14309

* Changelog: add #14304

* Changelog: add general connection log.

* Changelog: add #14275

* Changelog: add #14313

* Changelog: add #14213

* Changelog: add #14357

* Add sync testing instructions

* Add 8.1.1 changelog back

See eeaafab and 61757eb

* Changelog: add #14371

* Changelog: add #14386

* Changelog: add #14471

* Changelog: add #14325

* Changelog: add #14194

* Changelog: add #14340

* Changelog: add #14418

* Changelog: add #14417

* Changelog: add #14075

* Changelog: add #14467

* Changelog: add #14307

* Changelog: add #14326
@jeherve jeherve mentioned this pull request Feb 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

Assignees

@jsnajdr jsnajdr

Labels
Build Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended [Type] Janitorial
Projects
None yet
Milestone
8.2
Development

Successfully merging this pull request may close these issues.

Build: Dashboard, Instant Search, Blocks broken in IE11
5 participants
@matticbot @jetpackbot @jeherve @jsnajdr @renovate-bot