-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync: warning on update #15209
Comments
I just tested with the Jetpack beta plugin, trying to switch to a random feature branch and it failed with a fatal:
I think this issue is happening because there's a split moment when the "old" and "new" Jetpack code runs side by side and it's possible that it's failing because the Feature branch one is switching to might not be rebased to the latest I don't think this is an issue of the main Jetpack plugin, but more related to how the Beta plugin switches around the code. I'm not going to close this issue for the moment and I'm going to dig into how the Jetpack Beta plugins work to confirm. |
Looking at the code for the Jetpack Beta plugin and testing things out, this seems to be the case. In the method The problem occurs because we don't halt the "current" script execution immediately after the redirect and we execute all the handlers that come after the end of This (guessing due to the nature how code is loaded and executed) causes desync in the code where we load some code to be executed before the new plugin is activated. After the new code is put in place, we continue the execution flow and when we try to run the code that was loaded beforehand, it tries to load some of the functions to execute, but the files are not there or running an "older" version that doesn't have the code that needs to be executed and it causes either a Warning in A solution might be to just add an |
Pushed a PR that should fix the issue - Automattic/jetpack-beta#98 |
Fixed in Jetpack Beta plugin v2.4.3 |
#15056 seems to trigger warnings in some scenarios, like switching branches in the Beta plugin:
@bisko Do you think you could take a look at it?
Thank you!
The text was updated successfully, but these errors were encountered: