Switching to Live branch: Prevent code from executing after new code has been put in place. #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a result of Automattic/jetpack#15209 .
After switching to another branch that's not "current", compared to the "old" branch that we switch out of, can see warnings or errors in the error log.
This happens because we continue executing actions and shutdown handlers after the code on the filesystem is changed and this causes a desync in what it's supposed to do.
This PR adds a forced
exit()
after we redirect the user back to WP-Admin after the new branch has been put in place and options updated to make sure those actions and handlers are not executed and no errors are triggered.To test:
Since this relies on specific conditions to be met, generic testing is a bit hard.
For the moment it would work with the following instructions:
Bleeding edge
Jetpackfix / post by email refactoring
- Post by Email: Refactoring and Unit Tests jetpack#15139