-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking Package / tools: consolidate and document available tools #15929
Comments
Hey @jeherve 👋 My work on @roo2 was doing most of the work in taking pieces out of In any case, I'm happy to help where I can! |
Since @dereksmart and I worked on this and struggled to find out how to use these libs, I thought it would be a good idea to document it here how to use them (and then move it to the right place once we decide it) Tracks Ajax
This is useful to track simple click events without the need of any additional js. Just add the appropriate class to your links and it will be tracked. 1. enqueue script (no need)The required script is already loaded, at least in admin context. See 2. Add the class and the event attributes.Add the The event needs a name. This can be informed with the <a class="jptracks" data-jptracks-name="my-awesome-event">Click me</a> And that's it. Your event will be tracked. Every time this element is clicked an ajax call will be triggered to the Tracking package and it will send it to wpcom. 3. Additional parametersYou can also inform additional parameters to your event using the 4. Making your own ajax callsIn your JS you can set up your own ajax calls. Example: window.jpTracksAJAX.record_ajax_event( 'my_event_name', 'click', { prop1: value1, prop2: value2 } ); Note: Event name will be automatically prefixed with Waiting for the ajax call to complete before doing anything else If you need to do a subsequent action but wants to wait for this event to be tracked, you can do the following: window.jpTracksAJAX
.record_ajax_event( 'my_event_name', 'click', { prop1: value1, prop2: value2 } )
.always( function() {
// do something
} ); Tracks callable
This approach to track events uses 1. Enqueue the scriptsNote: We might change this so you don't need to register the scripts every time, and instead just add this as a dependency on your own. I'll came back here and update once we do so. wp_register_script(
'jp-tracks',
'//stats.wp.com/w.js',
array(),
gmdate( 'YW' ),
true
);
wp_register_script(
'jp-tracks-functions',
plugins_url( '_inc/lib/tracks/tracks-callables.js', JETPACK__PLUGIN_FILE ),
array( 'jp-tracks' ),
JETPACK__VERSION,
false
);
wp_enqueue_script( 'my_script', 'my-script.js', array( 'jp-tracks-functions' ) ); 2. Inform the user datawp_localize_script(
'my_script',
'varname',
array(
'tracksUserData' => Jetpack_Tracks_Client::get_connected_user_tracks_identity(),
)
); Track!var tracksUser = varname.tracksUserData;
analytics.initialize( tracksUser.userid, tracksUser.username );
analytics.tracks.recordEvent( 'jetpack_my_event_name', { prop1: value1, prop2: value2 } ); |
Hey I was the original one to break out the calypso-analytics library and can give you some context on that. We originally created it in order to add analytics to gutenboarding which is in effect a standalone react app. Original PR Currently as you may have seen, here's what I think are the pro's and con's of using calypso analytics for jetpack: Pro:
Con:
It looks to me like expanding calypso-analytics to work for jetpack too would be useful, but it won't quite be a drop in replacement without a bit of work. |
* Adding the tracks-callables.js file to the Tracking package. Related: #15929 * Adding changelog entry. * Removing the calls to wp_register_script() for the tracks-callable.js file. Removing the jp-tracks-functions slug from the array of script slugs. * Adding changelog entry. * Reverting the changes to class.jetpack.php. It seems we'll still need to enqueue the scripts here. * Adding the register_tracks_scripts() method. This will handle calling the wp_register_script() function for the tracks-callables.js file. In the class.jetpack.php file, replacing the call to the wp_register_script() function with the $tracking->register_tracks_scripts() method. * Calling the $tracking->register_tracks_scripts() method in the search widget. * Register jp-tracks dependency when registering jp-tracks-functions. Rename register function to destinguish it from the jptracks used in enqueue. Update register function to static to not instantiate class. Update dependencies to simplify only needed entries. * Update changelogger entry so Jetpack has changelog entry. * Update the register function to optionally enqueue. Necessary when other packages rely on the script but shouldn't be aware of file location details. * reverse conditional so more intuitive. Co-authored-by: Matthew Denton <matt@mdbitz.com>
* Adding the tracks-callables.js file to the Tracking package. Related: Automattic/jetpack#15929 * Adding changelog entry. * Removing the calls to wp_register_script() for the tracks-callable.js file. Removing the jp-tracks-functions slug from the array of script slugs. * Adding changelog entry. * Reverting the changes to class.jetpack.php. It seems we'll still need to enqueue the scripts here. * Adding the register_tracks_scripts() method. This will handle calling the wp_register_script() function for the tracks-callables.js file. In the class.jetpack.php file, replacing the call to the wp_register_script() function with the $tracking->register_tracks_scripts() method. * Calling the $tracking->register_tracks_scripts() method in the search widget. * Register jp-tracks dependency when registering jp-tracks-functions. Rename register function to destinguish it from the jptracks used in enqueue. Update register function to static to not instantiate class. Update dependencies to simplify only needed entries. * Update changelogger entry so Jetpack has changelog entry. * Update the register function to optionally enqueue. Necessary when other packages rely on the script but shouldn't be aware of file location details. * reverse conditional so more intuitive. Co-authored-by: Matthew Denton <matt@mdbitz.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/814434312
* Adding the tracks-callables.js file to the Tracking package. Related: Automattic/jetpack#15929 * Adding changelog entry. * Removing the calls to wp_register_script() for the tracks-callable.js file. Removing the jp-tracks-functions slug from the array of script slugs. * Adding changelog entry. * Reverting the changes to class.jetpack.php. It seems we'll still need to enqueue the scripts here. * Adding the register_tracks_scripts() method. This will handle calling the wp_register_script() function for the tracks-callables.js file. In the class.jetpack.php file, replacing the call to the wp_register_script() function with the $tracking->register_tracks_scripts() method. * Calling the $tracking->register_tracks_scripts() method in the search widget. * Register jp-tracks dependency when registering jp-tracks-functions. Rename register function to destinguish it from the jptracks used in enqueue. Update register function to static to not instantiate class. Update dependencies to simplify only needed entries. * Update changelogger entry so Jetpack has changelog entry. * Update the register function to optionally enqueue. Necessary when other packages rely on the script but shouldn't be aware of file location details. * reverse conditional so more intuitive. Co-authored-by: Matthew Denton <matt@mdbitz.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/814434312
* Initial skeleton for the Identity_Crisis package. Including the basic file and class structures for now. * Adding the initial version of the Identity_Crisis class copied from the Jetpack_IDC class. A lot of the code has been massaged/fixed to pass the phpcs checks. * Finally getting some of the dependencies resolved. The phpunit tests will actually run now. * Resolving the remaining Jetpack class dependencies. The methods used have all been copied to the Identity_Crisis class. * Updating the readme's usage section. * Making some changes to use the new Identity_Crisis package. Removing the old Jetpack_IDC class. * Adding the password-checker package back after rebase. * removing the identity-crisis package so that I can rebase. * Adding the identity-crisis package back after rebase. * Adding changelog entry. * Adding the changelogger package. * Adding changelog entry. * Removing the identity-crisis package directory. Should avoid a merge confict later on. * Removing the identity-crisis package so that I can rebase. * Adding changelog entry * Adding the identity-crisis package back after rebase. * Adding the idc-notice.js asset. * Adding tooling to handle building assets. * Adding a few other files I missed in the last commit. * Bumping the node version to 14. Adding the identity-crisis package to the Monorepo packages ignore list. * Building JS. * Adding the CSS assets. * Building SCSS * Adjust enqueueing of the built assets. * Adding CSS assets for jetpack-idc-admin-bar and jetpack-idc-admin-bar-rtl. * Adding the tracks-callables.js file to the Tracking package. Related: #15929 * Adding changelog entry. * Adding the Tracking package. Using the Tracking package's enqueue_tracks_scripts() method to handle the JS assets. * Removing the calls to wp_register_script() for the tracks-callable.js file. Removing the jp-tracks-functions slug from the array of script slugs. * Adding changelog entry. * Reverting the changes to class.jetpack.php. It seems we'll still need to enqueue the scripts here. * Adding the register_tracks_scripts() method. This will handle calling the wp_register_script() function for the tracks-callables.js file. In the class.jetpack.php file, replacing the call to the wp_register_script() function with the $tracking->register_tracks_scripts() method. * Call the new register_tracks_scripts() method that will soon exist in the Tracking package. * Calling the $tracking->register_tracks_scripts() method in the search widget. * Register jp-tracks dependency when registering jp-tracks-functions. Rename register function to destinguish it from the jptracks used in enqueue. Update register function to static to not instantiate class. Update dependencies to simplify only needed entries. * Update changelogger entry so Jetpack has changelog entry. * [not verified] Composer Updates to have dependency versions and meta as outlined by linting. Identity Crisis class has PACKAGE_VERSION attribute Update Identity Crisis to enqueue based on correct paths and versions. js file updated to have jsdocs, and updated var to let and const as appropriate. Webpack config updated to remove the polyfill that isn't required. Deleted rtl file that is auto-generated. * maintain current versions as we haven't switched to package aware * Update the register function to optionally enqueue. Necessary when other packages rely on the script but shouldn't be aware of file location details. * Update Sync Pakcage to have Identity_Crisis as a dependency. Update Sync Configure to call Identity_Crisis init Deprecation of Jetpack idc functions that are migrated to Identity Crisis package. Update Jetpack references to Identity Crisis. * Copy Admin.css to package (unblock Backup development. add _color.scss and color.scss to compare tool to ensure they remain aligned. composer version fix for wordbless. * reverse conditional so more intuitive. * Update references from Jetpack:: to Identity_Crisis for migrated methods. * remove tracks-callables.js from previous location. * remove migrated idc-notice.js file * Updated version using tools/project-version.sh * [not verified] Update dependency to proper versions. maintain class.jetpack-idc.php to avoid fatals during upgrade routines. Add proper use calls to files * Migrate home_url and site_url into Identity Crisis package to break dependency cycle. * remove Identity Crisis dependency on Sync. Migrate loading of IDC back to Jetpack. * missed update to Identity_Crisis/Functions from Sync/Functions * Fix typo and composer version. * proper package name jetpack-* * dependency updates to 1.22.x-dev for sync * tools/check-composer-deps.sh -u * Changelog update. * Update Status reference to deprecated class * Connection changelog * Updated the function check not the reference. * another round of dependency updates * Sync tests updated to use Identity_Functions * Another round of composer updates * More version dependency updates. * Changelog for jitm * Remove link idc-notice.js from exclude list. * update composer lock file * bump composer lock * Changelog * Migrate url functions into the Utils class of the Connection Package. * Missed update to callables, confirms our check for function exists is stopping fatals. * Update readme with instructions on how to initialize Identity Crisis flows. * Migration from Utils to Urls * Undo escapes, add PHPCS Update to use is_connected instead of deprecated is_active * Updated lock file * Missing use statement. * Build Assets should use require to get the array with version information. * Fix Build inclusion in mirror * Update docblock * remove contents of Jetpack_IDC class file * Update projects/packages/connection/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/identity-crisis/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update composer mismatch to 1.28.x-dev * Update Connection 1.28 dependency and lock * Version updates to connection 1.28 * Backup composer lock * Changelog and lock file updates Co-authored-by: Brad Jorsch <brad.jorsch@automattic.com> Co-authored-by: Sergey Mitroshin <sergeymitr@gmail.com> Co-authored-by: Brandon Kraft <public@brandonkraft.com> Co-authored-by: Matthew Denton <matt@mdbitz.com> Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com>
* Initial skeleton for the Identity_Crisis package. Including the basic file and class structures for now. * Adding the initial version of the Identity_Crisis class copied from the Jetpack_IDC class. A lot of the code has been massaged/fixed to pass the phpcs checks. * Finally getting some of the dependencies resolved. The phpunit tests will actually run now. * Resolving the remaining Jetpack class dependencies. The methods used have all been copied to the Identity_Crisis class. * Updating the readme's usage section. * Making some changes to use the new Identity_Crisis package. Removing the old Jetpack_IDC class. * Adding the password-checker package back after rebase. * removing the identity-crisis package so that I can rebase. * Adding the identity-crisis package back after rebase. * Adding changelog entry. * Adding the changelogger package. * Adding changelog entry. * Removing the identity-crisis package directory. Should avoid a merge confict later on. * Removing the identity-crisis package so that I can rebase. * Adding changelog entry * Adding the identity-crisis package back after rebase. * Adding the idc-notice.js asset. * Adding tooling to handle building assets. * Adding a few other files I missed in the last commit. * Bumping the node version to 14. Adding the identity-crisis package to the Monorepo packages ignore list. * Building JS. * Adding the CSS assets. * Building SCSS * Adjust enqueueing of the built assets. * Adding CSS assets for jetpack-idc-admin-bar and jetpack-idc-admin-bar-rtl. * Adding the tracks-callables.js file to the Tracking package. Related: Automattic/jetpack#15929 * Adding changelog entry. * Adding the Tracking package. Using the Tracking package's enqueue_tracks_scripts() method to handle the JS assets. * Removing the calls to wp_register_script() for the tracks-callable.js file. Removing the jp-tracks-functions slug from the array of script slugs. * Adding changelog entry. * Reverting the changes to class.jetpack.php. It seems we'll still need to enqueue the scripts here. * Adding the register_tracks_scripts() method. This will handle calling the wp_register_script() function for the tracks-callables.js file. In the class.jetpack.php file, replacing the call to the wp_register_script() function with the $tracking->register_tracks_scripts() method. * Call the new register_tracks_scripts() method that will soon exist in the Tracking package. * Calling the $tracking->register_tracks_scripts() method in the search widget. * Register jp-tracks dependency when registering jp-tracks-functions. Rename register function to destinguish it from the jptracks used in enqueue. Update register function to static to not instantiate class. Update dependencies to simplify only needed entries. * Update changelogger entry so Jetpack has changelog entry. * [not verified] Composer Updates to have dependency versions and meta as outlined by linting. Identity Crisis class has PACKAGE_VERSION attribute Update Identity Crisis to enqueue based on correct paths and versions. js file updated to have jsdocs, and updated var to let and const as appropriate. Webpack config updated to remove the polyfill that isn't required. Deleted rtl file that is auto-generated. * maintain current versions as we haven't switched to package aware * Update the register function to optionally enqueue. Necessary when other packages rely on the script but shouldn't be aware of file location details. * Update Sync Pakcage to have Identity_Crisis as a dependency. Update Sync Configure to call Identity_Crisis init Deprecation of Jetpack idc functions that are migrated to Identity Crisis package. Update Jetpack references to Identity Crisis. * Copy Admin.css to package (unblock Backup development. add _color.scss and color.scss to compare tool to ensure they remain aligned. composer version fix for wordbless. * reverse conditional so more intuitive. * Update references from Jetpack:: to Identity_Crisis for migrated methods. * remove tracks-callables.js from previous location. * remove migrated idc-notice.js file * Updated version using tools/project-version.sh * [not verified] Update dependency to proper versions. maintain class.jetpack-idc.php to avoid fatals during upgrade routines. Add proper use calls to files * Migrate home_url and site_url into Identity Crisis package to break dependency cycle. * remove Identity Crisis dependency on Sync. Migrate loading of IDC back to Jetpack. * missed update to Identity_Crisis/Functions from Sync/Functions * Fix typo and composer version. * proper package name jetpack-* * dependency updates to 1.22.x-dev for sync * tools/check-composer-deps.sh -u * Changelog update. * Update Status reference to deprecated class * Connection changelog * Updated the function check not the reference. * another round of dependency updates * Sync tests updated to use Identity_Functions * Another round of composer updates * More version dependency updates. * Changelog for jitm * Remove link idc-notice.js from exclude list. * update composer lock file * bump composer lock * Changelog * Migrate url functions into the Utils class of the Connection Package. * Missed update to callables, confirms our check for function exists is stopping fatals. * Update readme with instructions on how to initialize Identity Crisis flows. * Migration from Utils to Urls * Undo escapes, add PHPCS Update to use is_connected instead of deprecated is_active * Updated lock file * Missing use statement. * Build Assets should use require to get the array with version information. * Fix Build inclusion in mirror * Update docblock * remove contents of Jetpack_IDC class file * Update projects/packages/connection/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/identity-crisis/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update composer mismatch to 1.28.x-dev * Update Connection 1.28 dependency and lock * Version updates to connection 1.28 * Backup composer lock * Changelog and lock file updates Co-authored-by: Brad Jorsch <brad.jorsch@automattic.com> Co-authored-by: Sergey Mitroshin <sergeymitr@gmail.com> Co-authored-by: Brandon Kraft <public@brandonkraft.com> Co-authored-by: Matthew Denton <matt@mdbitz.com> Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/879621148
* Initial skeleton for the Identity_Crisis package. Including the basic file and class structures for now. * Adding the initial version of the Identity_Crisis class copied from the Jetpack_IDC class. A lot of the code has been massaged/fixed to pass the phpcs checks. * Finally getting some of the dependencies resolved. The phpunit tests will actually run now. * Resolving the remaining Jetpack class dependencies. The methods used have all been copied to the Identity_Crisis class. * Updating the readme's usage section. * Making some changes to use the new Identity_Crisis package. Removing the old Jetpack_IDC class. * Adding the password-checker package back after rebase. * removing the identity-crisis package so that I can rebase. * Adding the identity-crisis package back after rebase. * Adding changelog entry. * Adding the changelogger package. * Adding changelog entry. * Removing the identity-crisis package directory. Should avoid a merge confict later on. * Removing the identity-crisis package so that I can rebase. * Adding changelog entry * Adding the identity-crisis package back after rebase. * Adding the idc-notice.js asset. * Adding tooling to handle building assets. * Adding a few other files I missed in the last commit. * Bumping the node version to 14. Adding the identity-crisis package to the Monorepo packages ignore list. * Building JS. * Adding the CSS assets. * Building SCSS * Adjust enqueueing of the built assets. * Adding CSS assets for jetpack-idc-admin-bar and jetpack-idc-admin-bar-rtl. * Adding the tracks-callables.js file to the Tracking package. Related: Automattic/jetpack#15929 * Adding changelog entry. * Adding the Tracking package. Using the Tracking package's enqueue_tracks_scripts() method to handle the JS assets. * Removing the calls to wp_register_script() for the tracks-callable.js file. Removing the jp-tracks-functions slug from the array of script slugs. * Adding changelog entry. * Reverting the changes to class.jetpack.php. It seems we'll still need to enqueue the scripts here. * Adding the register_tracks_scripts() method. This will handle calling the wp_register_script() function for the tracks-callables.js file. In the class.jetpack.php file, replacing the call to the wp_register_script() function with the $tracking->register_tracks_scripts() method. * Call the new register_tracks_scripts() method that will soon exist in the Tracking package. * Calling the $tracking->register_tracks_scripts() method in the search widget. * Register jp-tracks dependency when registering jp-tracks-functions. Rename register function to destinguish it from the jptracks used in enqueue. Update register function to static to not instantiate class. Update dependencies to simplify only needed entries. * Update changelogger entry so Jetpack has changelog entry. * [not verified] Composer Updates to have dependency versions and meta as outlined by linting. Identity Crisis class has PACKAGE_VERSION attribute Update Identity Crisis to enqueue based on correct paths and versions. js file updated to have jsdocs, and updated var to let and const as appropriate. Webpack config updated to remove the polyfill that isn't required. Deleted rtl file that is auto-generated. * maintain current versions as we haven't switched to package aware * Update the register function to optionally enqueue. Necessary when other packages rely on the script but shouldn't be aware of file location details. * Update Sync Pakcage to have Identity_Crisis as a dependency. Update Sync Configure to call Identity_Crisis init Deprecation of Jetpack idc functions that are migrated to Identity Crisis package. Update Jetpack references to Identity Crisis. * Copy Admin.css to package (unblock Backup development. add _color.scss and color.scss to compare tool to ensure they remain aligned. composer version fix for wordbless. * reverse conditional so more intuitive. * Update references from Jetpack:: to Identity_Crisis for migrated methods. * remove tracks-callables.js from previous location. * remove migrated idc-notice.js file * Updated version using tools/project-version.sh * [not verified] Update dependency to proper versions. maintain class.jetpack-idc.php to avoid fatals during upgrade routines. Add proper use calls to files * Migrate home_url and site_url into Identity Crisis package to break dependency cycle. * remove Identity Crisis dependency on Sync. Migrate loading of IDC back to Jetpack. * missed update to Identity_Crisis/Functions from Sync/Functions * Fix typo and composer version. * proper package name jetpack-* * dependency updates to 1.22.x-dev for sync * tools/check-composer-deps.sh -u * Changelog update. * Update Status reference to deprecated class * Connection changelog * Updated the function check not the reference. * another round of dependency updates * Sync tests updated to use Identity_Functions * Another round of composer updates * More version dependency updates. * Changelog for jitm * Remove link idc-notice.js from exclude list. * update composer lock file * bump composer lock * Changelog * Migrate url functions into the Utils class of the Connection Package. * Missed update to callables, confirms our check for function exists is stopping fatals. * Update readme with instructions on how to initialize Identity Crisis flows. * Migration from Utils to Urls * Undo escapes, add PHPCS Update to use is_connected instead of deprecated is_active * Updated lock file * Missing use statement. * Build Assets should use require to get the array with version information. * Fix Build inclusion in mirror * Update docblock * remove contents of Jetpack_IDC class file * Update projects/packages/connection/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/identity-crisis/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update composer mismatch to 1.28.x-dev * Update Connection 1.28 dependency and lock * Version updates to connection 1.28 * Backup composer lock * Changelog and lock file updates Co-authored-by: Brad Jorsch <brad.jorsch@automattic.com> Co-authored-by: Sergey Mitroshin <sergeymitr@gmail.com> Co-authored-by: Brandon Kraft <public@brandonkraft.com> Co-authored-by: Matthew Denton <matt@mdbitz.com> Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/879621148
* Initial skeleton for the Identity_Crisis package. Including the basic file and class structures for now. * Adding the initial version of the Identity_Crisis class copied from the Jetpack_IDC class. A lot of the code has been massaged/fixed to pass the phpcs checks. * Finally getting some of the dependencies resolved. The phpunit tests will actually run now. * Resolving the remaining Jetpack class dependencies. The methods used have all been copied to the Identity_Crisis class. * Updating the readme's usage section. * Making some changes to use the new Identity_Crisis package. Removing the old Jetpack_IDC class. * Adding the password-checker package back after rebase. * removing the identity-crisis package so that I can rebase. * Adding the identity-crisis package back after rebase. * Adding changelog entry. * Adding the changelogger package. * Adding changelog entry. * Removing the identity-crisis package directory. Should avoid a merge confict later on. * Removing the identity-crisis package so that I can rebase. * Adding changelog entry * Adding the identity-crisis package back after rebase. * Adding the idc-notice.js asset. * Adding tooling to handle building assets. * Adding a few other files I missed in the last commit. * Bumping the node version to 14. Adding the identity-crisis package to the Monorepo packages ignore list. * Building JS. * Adding the CSS assets. * Building SCSS * Adjust enqueueing of the built assets. * Adding CSS assets for jetpack-idc-admin-bar and jetpack-idc-admin-bar-rtl. * Adding the tracks-callables.js file to the Tracking package. Related: Automattic/jetpack#15929 * Adding changelog entry. * Adding the Tracking package. Using the Tracking package's enqueue_tracks_scripts() method to handle the JS assets. * Removing the calls to wp_register_script() for the tracks-callable.js file. Removing the jp-tracks-functions slug from the array of script slugs. * Adding changelog entry. * Reverting the changes to class.jetpack.php. It seems we'll still need to enqueue the scripts here. * Adding the register_tracks_scripts() method. This will handle calling the wp_register_script() function for the tracks-callables.js file. In the class.jetpack.php file, replacing the call to the wp_register_script() function with the $tracking->register_tracks_scripts() method. * Call the new register_tracks_scripts() method that will soon exist in the Tracking package. * Calling the $tracking->register_tracks_scripts() method in the search widget. * Register jp-tracks dependency when registering jp-tracks-functions. Rename register function to destinguish it from the jptracks used in enqueue. Update register function to static to not instantiate class. Update dependencies to simplify only needed entries. * Update changelogger entry so Jetpack has changelog entry. * [not verified] Composer Updates to have dependency versions and meta as outlined by linting. Identity Crisis class has PACKAGE_VERSION attribute Update Identity Crisis to enqueue based on correct paths and versions. js file updated to have jsdocs, and updated var to let and const as appropriate. Webpack config updated to remove the polyfill that isn't required. Deleted rtl file that is auto-generated. * maintain current versions as we haven't switched to package aware * Update the register function to optionally enqueue. Necessary when other packages rely on the script but shouldn't be aware of file location details. * Update Sync Pakcage to have Identity_Crisis as a dependency. Update Sync Configure to call Identity_Crisis init Deprecation of Jetpack idc functions that are migrated to Identity Crisis package. Update Jetpack references to Identity Crisis. * Copy Admin.css to package (unblock Backup development. add _color.scss and color.scss to compare tool to ensure they remain aligned. composer version fix for wordbless. * reverse conditional so more intuitive. * Update references from Jetpack:: to Identity_Crisis for migrated methods. * remove tracks-callables.js from previous location. * remove migrated idc-notice.js file * Updated version using tools/project-version.sh * [not verified] Update dependency to proper versions. maintain class.jetpack-idc.php to avoid fatals during upgrade routines. Add proper use calls to files * Migrate home_url and site_url into Identity Crisis package to break dependency cycle. * remove Identity Crisis dependency on Sync. Migrate loading of IDC back to Jetpack. * missed update to Identity_Crisis/Functions from Sync/Functions * Fix typo and composer version. * proper package name jetpack-* * dependency updates to 1.22.x-dev for sync * tools/check-composer-deps.sh -u * Changelog update. * Update Status reference to deprecated class * Connection changelog * Updated the function check not the reference. * another round of dependency updates * Sync tests updated to use Identity_Functions * Another round of composer updates * More version dependency updates. * Changelog for jitm * Remove link idc-notice.js from exclude list. * update composer lock file * bump composer lock * Changelog * Migrate url functions into the Utils class of the Connection Package. * Missed update to callables, confirms our check for function exists is stopping fatals. * Update readme with instructions on how to initialize Identity Crisis flows. * Migration from Utils to Urls * Undo escapes, add PHPCS Update to use is_connected instead of deprecated is_active * Updated lock file * Missing use statement. * Build Assets should use require to get the array with version information. * Fix Build inclusion in mirror * Update docblock * remove contents of Jetpack_IDC class file * Update projects/packages/connection/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/identity-crisis/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update composer mismatch to 1.28.x-dev * Update Connection 1.28 dependency and lock * Version updates to connection 1.28 * Backup composer lock * Changelog and lock file updates Co-authored-by: Brad Jorsch <brad.jorsch@automattic.com> Co-authored-by: Sergey Mitroshin <sergeymitr@gmail.com> Co-authored-by: Brandon Kraft <public@brandonkraft.com> Co-authored-by: Matthew Denton <matt@mdbitz.com> Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/879621148
* Initial skeleton for the Identity_Crisis package. Including the basic file and class structures for now. * Adding the initial version of the Identity_Crisis class copied from the Jetpack_IDC class. A lot of the code has been massaged/fixed to pass the phpcs checks. * Finally getting some of the dependencies resolved. The phpunit tests will actually run now. * Resolving the remaining Jetpack class dependencies. The methods used have all been copied to the Identity_Crisis class. * Updating the readme's usage section. * Making some changes to use the new Identity_Crisis package. Removing the old Jetpack_IDC class. * Adding the password-checker package back after rebase. * removing the identity-crisis package so that I can rebase. * Adding the identity-crisis package back after rebase. * Adding changelog entry. * Adding the changelogger package. * Adding changelog entry. * Removing the identity-crisis package directory. Should avoid a merge confict later on. * Removing the identity-crisis package so that I can rebase. * Adding changelog entry * Adding the identity-crisis package back after rebase. * Adding the idc-notice.js asset. * Adding tooling to handle building assets. * Adding a few other files I missed in the last commit. * Bumping the node version to 14. Adding the identity-crisis package to the Monorepo packages ignore list. * Building JS. * Adding the CSS assets. * Building SCSS * Adjust enqueueing of the built assets. * Adding CSS assets for jetpack-idc-admin-bar and jetpack-idc-admin-bar-rtl. * Adding the tracks-callables.js file to the Tracking package. Related: Automattic/jetpack#15929 * Adding changelog entry. * Adding the Tracking package. Using the Tracking package's enqueue_tracks_scripts() method to handle the JS assets. * Removing the calls to wp_register_script() for the tracks-callable.js file. Removing the jp-tracks-functions slug from the array of script slugs. * Adding changelog entry. * Reverting the changes to class.jetpack.php. It seems we'll still need to enqueue the scripts here. * Adding the register_tracks_scripts() method. This will handle calling the wp_register_script() function for the tracks-callables.js file. In the class.jetpack.php file, replacing the call to the wp_register_script() function with the $tracking->register_tracks_scripts() method. * Call the new register_tracks_scripts() method that will soon exist in the Tracking package. * Calling the $tracking->register_tracks_scripts() method in the search widget. * Register jp-tracks dependency when registering jp-tracks-functions. Rename register function to destinguish it from the jptracks used in enqueue. Update register function to static to not instantiate class. Update dependencies to simplify only needed entries. * Update changelogger entry so Jetpack has changelog entry. * [not verified] Composer Updates to have dependency versions and meta as outlined by linting. Identity Crisis class has PACKAGE_VERSION attribute Update Identity Crisis to enqueue based on correct paths and versions. js file updated to have jsdocs, and updated var to let and const as appropriate. Webpack config updated to remove the polyfill that isn't required. Deleted rtl file that is auto-generated. * maintain current versions as we haven't switched to package aware * Update the register function to optionally enqueue. Necessary when other packages rely on the script but shouldn't be aware of file location details. * Update Sync Pakcage to have Identity_Crisis as a dependency. Update Sync Configure to call Identity_Crisis init Deprecation of Jetpack idc functions that are migrated to Identity Crisis package. Update Jetpack references to Identity Crisis. * Copy Admin.css to package (unblock Backup development. add _color.scss and color.scss to compare tool to ensure they remain aligned. composer version fix for wordbless. * reverse conditional so more intuitive. * Update references from Jetpack:: to Identity_Crisis for migrated methods. * remove tracks-callables.js from previous location. * remove migrated idc-notice.js file * Updated version using tools/project-version.sh * [not verified] Update dependency to proper versions. maintain class.jetpack-idc.php to avoid fatals during upgrade routines. Add proper use calls to files * Migrate home_url and site_url into Identity Crisis package to break dependency cycle. * remove Identity Crisis dependency on Sync. Migrate loading of IDC back to Jetpack. * missed update to Identity_Crisis/Functions from Sync/Functions * Fix typo and composer version. * proper package name jetpack-* * dependency updates to 1.22.x-dev for sync * tools/check-composer-deps.sh -u * Changelog update. * Update Status reference to deprecated class * Connection changelog * Updated the function check not the reference. * another round of dependency updates * Sync tests updated to use Identity_Functions * Another round of composer updates * More version dependency updates. * Changelog for jitm * Remove link idc-notice.js from exclude list. * update composer lock file * bump composer lock * Changelog * Migrate url functions into the Utils class of the Connection Package. * Missed update to callables, confirms our check for function exists is stopping fatals. * Update readme with instructions on how to initialize Identity Crisis flows. * Migration from Utils to Urls * Undo escapes, add PHPCS Update to use is_connected instead of deprecated is_active * Updated lock file * Missing use statement. * Build Assets should use require to get the array with version information. * Fix Build inclusion in mirror * Update docblock * remove contents of Jetpack_IDC class file * Update projects/packages/connection/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/identity-crisis/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update composer mismatch to 1.28.x-dev * Update Connection 1.28 dependency and lock * Version updates to connection 1.28 * Backup composer lock * Changelog and lock file updates Co-authored-by: Brad Jorsch <brad.jorsch@automattic.com> Co-authored-by: Sergey Mitroshin <sergeymitr@gmail.com> Co-authored-by: Brandon Kraft <public@brandonkraft.com> Co-authored-by: Matthew Denton <matt@mdbitz.com> Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/879621148
* Initial skeleton for the Identity_Crisis package. Including the basic file and class structures for now. * Adding the initial version of the Identity_Crisis class copied from the Jetpack_IDC class. A lot of the code has been massaged/fixed to pass the phpcs checks. * Finally getting some of the dependencies resolved. The phpunit tests will actually run now. * Resolving the remaining Jetpack class dependencies. The methods used have all been copied to the Identity_Crisis class. * Updating the readme's usage section. * Making some changes to use the new Identity_Crisis package. Removing the old Jetpack_IDC class. * Adding the password-checker package back after rebase. * removing the identity-crisis package so that I can rebase. * Adding the identity-crisis package back after rebase. * Adding changelog entry. * Adding the changelogger package. * Adding changelog entry. * Removing the identity-crisis package directory. Should avoid a merge confict later on. * Removing the identity-crisis package so that I can rebase. * Adding changelog entry * Adding the identity-crisis package back after rebase. * Adding the idc-notice.js asset. * Adding tooling to handle building assets. * Adding a few other files I missed in the last commit. * Bumping the node version to 14. Adding the identity-crisis package to the Monorepo packages ignore list. * Building JS. * Adding the CSS assets. * Building SCSS * Adjust enqueueing of the built assets. * Adding CSS assets for jetpack-idc-admin-bar and jetpack-idc-admin-bar-rtl. * Adding the tracks-callables.js file to the Tracking package. Related: Automattic/jetpack#15929 * Adding changelog entry. * Adding the Tracking package. Using the Tracking package's enqueue_tracks_scripts() method to handle the JS assets. * Removing the calls to wp_register_script() for the tracks-callable.js file. Removing the jp-tracks-functions slug from the array of script slugs. * Adding changelog entry. * Reverting the changes to class.jetpack.php. It seems we'll still need to enqueue the scripts here. * Adding the register_tracks_scripts() method. This will handle calling the wp_register_script() function for the tracks-callables.js file. In the class.jetpack.php file, replacing the call to the wp_register_script() function with the $tracking->register_tracks_scripts() method. * Call the new register_tracks_scripts() method that will soon exist in the Tracking package. * Calling the $tracking->register_tracks_scripts() method in the search widget. * Register jp-tracks dependency when registering jp-tracks-functions. Rename register function to destinguish it from the jptracks used in enqueue. Update register function to static to not instantiate class. Update dependencies to simplify only needed entries. * Update changelogger entry so Jetpack has changelog entry. * [not verified] Composer Updates to have dependency versions and meta as outlined by linting. Identity Crisis class has PACKAGE_VERSION attribute Update Identity Crisis to enqueue based on correct paths and versions. js file updated to have jsdocs, and updated var to let and const as appropriate. Webpack config updated to remove the polyfill that isn't required. Deleted rtl file that is auto-generated. * maintain current versions as we haven't switched to package aware * Update the register function to optionally enqueue. Necessary when other packages rely on the script but shouldn't be aware of file location details. * Update Sync Pakcage to have Identity_Crisis as a dependency. Update Sync Configure to call Identity_Crisis init Deprecation of Jetpack idc functions that are migrated to Identity Crisis package. Update Jetpack references to Identity Crisis. * Copy Admin.css to package (unblock Backup development. add _color.scss and color.scss to compare tool to ensure they remain aligned. composer version fix for wordbless. * reverse conditional so more intuitive. * Update references from Jetpack:: to Identity_Crisis for migrated methods. * remove tracks-callables.js from previous location. * remove migrated idc-notice.js file * Updated version using tools/project-version.sh * [not verified] Update dependency to proper versions. maintain class.jetpack-idc.php to avoid fatals during upgrade routines. Add proper use calls to files * Migrate home_url and site_url into Identity Crisis package to break dependency cycle. * remove Identity Crisis dependency on Sync. Migrate loading of IDC back to Jetpack. * missed update to Identity_Crisis/Functions from Sync/Functions * Fix typo and composer version. * proper package name jetpack-* * dependency updates to 1.22.x-dev for sync * tools/check-composer-deps.sh -u * Changelog update. * Update Status reference to deprecated class * Connection changelog * Updated the function check not the reference. * another round of dependency updates * Sync tests updated to use Identity_Functions * Another round of composer updates * More version dependency updates. * Changelog for jitm * Remove link idc-notice.js from exclude list. * update composer lock file * bump composer lock * Changelog * Migrate url functions into the Utils class of the Connection Package. * Missed update to callables, confirms our check for function exists is stopping fatals. * Update readme with instructions on how to initialize Identity Crisis flows. * Migration from Utils to Urls * Undo escapes, add PHPCS Update to use is_connected instead of deprecated is_active * Updated lock file * Missing use statement. * Build Assets should use require to get the array with version information. * Fix Build inclusion in mirror * Update docblock * remove contents of Jetpack_IDC class file * Update projects/packages/connection/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/identity-crisis/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update composer mismatch to 1.28.x-dev * Update Connection 1.28 dependency and lock * Version updates to connection 1.28 * Backup composer lock * Changelog and lock file updates Co-authored-by: Brad Jorsch <brad.jorsch@automattic.com> Co-authored-by: Sergey Mitroshin <sergeymitr@gmail.com> Co-authored-by: Brandon Kraft <public@brandonkraft.com> Co-authored-by: Matthew Denton <matt@mdbitz.com> Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/879621148
* Initial skeleton for the Identity_Crisis package. Including the basic file and class structures for now. * Adding the initial version of the Identity_Crisis class copied from the Jetpack_IDC class. A lot of the code has been massaged/fixed to pass the phpcs checks. * Finally getting some of the dependencies resolved. The phpunit tests will actually run now. * Resolving the remaining Jetpack class dependencies. The methods used have all been copied to the Identity_Crisis class. * Updating the readme's usage section. * Making some changes to use the new Identity_Crisis package. Removing the old Jetpack_IDC class. * Adding the password-checker package back after rebase. * removing the identity-crisis package so that I can rebase. * Adding the identity-crisis package back after rebase. * Adding changelog entry. * Adding the changelogger package. * Adding changelog entry. * Removing the identity-crisis package directory. Should avoid a merge confict later on. * Removing the identity-crisis package so that I can rebase. * Adding changelog entry * Adding the identity-crisis package back after rebase. * Adding the idc-notice.js asset. * Adding tooling to handle building assets. * Adding a few other files I missed in the last commit. * Bumping the node version to 14. Adding the identity-crisis package to the Monorepo packages ignore list. * Building JS. * Adding the CSS assets. * Building SCSS * Adjust enqueueing of the built assets. * Adding CSS assets for jetpack-idc-admin-bar and jetpack-idc-admin-bar-rtl. * Adding the tracks-callables.js file to the Tracking package. Related: Automattic/jetpack#15929 * Adding changelog entry. * Adding the Tracking package. Using the Tracking package's enqueue_tracks_scripts() method to handle the JS assets. * Removing the calls to wp_register_script() for the tracks-callable.js file. Removing the jp-tracks-functions slug from the array of script slugs. * Adding changelog entry. * Reverting the changes to class.jetpack.php. It seems we'll still need to enqueue the scripts here. * Adding the register_tracks_scripts() method. This will handle calling the wp_register_script() function for the tracks-callables.js file. In the class.jetpack.php file, replacing the call to the wp_register_script() function with the $tracking->register_tracks_scripts() method. * Call the new register_tracks_scripts() method that will soon exist in the Tracking package. * Calling the $tracking->register_tracks_scripts() method in the search widget. * Register jp-tracks dependency when registering jp-tracks-functions. Rename register function to destinguish it from the jptracks used in enqueue. Update register function to static to not instantiate class. Update dependencies to simplify only needed entries. * Update changelogger entry so Jetpack has changelog entry. * [not verified] Composer Updates to have dependency versions and meta as outlined by linting. Identity Crisis class has PACKAGE_VERSION attribute Update Identity Crisis to enqueue based on correct paths and versions. js file updated to have jsdocs, and updated var to let and const as appropriate. Webpack config updated to remove the polyfill that isn't required. Deleted rtl file that is auto-generated. * maintain current versions as we haven't switched to package aware * Update the register function to optionally enqueue. Necessary when other packages rely on the script but shouldn't be aware of file location details. * Update Sync Pakcage to have Identity_Crisis as a dependency. Update Sync Configure to call Identity_Crisis init Deprecation of Jetpack idc functions that are migrated to Identity Crisis package. Update Jetpack references to Identity Crisis. * Copy Admin.css to package (unblock Backup development. add _color.scss and color.scss to compare tool to ensure they remain aligned. composer version fix for wordbless. * reverse conditional so more intuitive. * Update references from Jetpack:: to Identity_Crisis for migrated methods. * remove tracks-callables.js from previous location. * remove migrated idc-notice.js file * Updated version using tools/project-version.sh * [not verified] Update dependency to proper versions. maintain class.jetpack-idc.php to avoid fatals during upgrade routines. Add proper use calls to files * Migrate home_url and site_url into Identity Crisis package to break dependency cycle. * remove Identity Crisis dependency on Sync. Migrate loading of IDC back to Jetpack. * missed update to Identity_Crisis/Functions from Sync/Functions * Fix typo and composer version. * proper package name jetpack-* * dependency updates to 1.22.x-dev for sync * tools/check-composer-deps.sh -u * Changelog update. * Update Status reference to deprecated class * Connection changelog * Updated the function check not the reference. * another round of dependency updates * Sync tests updated to use Identity_Functions * Another round of composer updates * More version dependency updates. * Changelog for jitm * Remove link idc-notice.js from exclude list. * update composer lock file * bump composer lock * Changelog * Migrate url functions into the Utils class of the Connection Package. * Missed update to callables, confirms our check for function exists is stopping fatals. * Update readme with instructions on how to initialize Identity Crisis flows. * Migration from Utils to Urls * Undo escapes, add PHPCS Update to use is_connected instead of deprecated is_active * Updated lock file * Missing use statement. * Build Assets should use require to get the array with version information. * Fix Build inclusion in mirror * Update docblock * remove contents of Jetpack_IDC class file * Update projects/packages/connection/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/identity-crisis/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update composer mismatch to 1.28.x-dev * Update Connection 1.28 dependency and lock * Version updates to connection 1.28 * Backup composer lock * Changelog and lock file updates Co-authored-by: Brad Jorsch <brad.jorsch@automattic.com> Co-authored-by: Sergey Mitroshin <sergeymitr@gmail.com> Co-authored-by: Brandon Kraft <public@brandonkraft.com> Co-authored-by: Matthew Denton <matt@mdbitz.com> Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/879621148
* Initial skeleton for the Identity_Crisis package. Including the basic file and class structures for now. * Adding the initial version of the Identity_Crisis class copied from the Jetpack_IDC class. A lot of the code has been massaged/fixed to pass the phpcs checks. * Finally getting some of the dependencies resolved. The phpunit tests will actually run now. * Resolving the remaining Jetpack class dependencies. The methods used have all been copied to the Identity_Crisis class. * Updating the readme's usage section. * Making some changes to use the new Identity_Crisis package. Removing the old Jetpack_IDC class. * Adding the password-checker package back after rebase. * removing the identity-crisis package so that I can rebase. * Adding the identity-crisis package back after rebase. * Adding changelog entry. * Adding the changelogger package. * Adding changelog entry. * Removing the identity-crisis package directory. Should avoid a merge confict later on. * Removing the identity-crisis package so that I can rebase. * Adding changelog entry * Adding the identity-crisis package back after rebase. * Adding the idc-notice.js asset. * Adding tooling to handle building assets. * Adding a few other files I missed in the last commit. * Bumping the node version to 14. Adding the identity-crisis package to the Monorepo packages ignore list. * Building JS. * Adding the CSS assets. * Building SCSS * Adjust enqueueing of the built assets. * Adding CSS assets for jetpack-idc-admin-bar and jetpack-idc-admin-bar-rtl. * Adding the tracks-callables.js file to the Tracking package. Related: Automattic/jetpack#15929 * Adding changelog entry. * Adding the Tracking package. Using the Tracking package's enqueue_tracks_scripts() method to handle the JS assets. * Removing the calls to wp_register_script() for the tracks-callable.js file. Removing the jp-tracks-functions slug from the array of script slugs. * Adding changelog entry. * Reverting the changes to class.jetpack.php. It seems we'll still need to enqueue the scripts here. * Adding the register_tracks_scripts() method. This will handle calling the wp_register_script() function for the tracks-callables.js file. In the class.jetpack.php file, replacing the call to the wp_register_script() function with the $tracking->register_tracks_scripts() method. * Call the new register_tracks_scripts() method that will soon exist in the Tracking package. * Calling the $tracking->register_tracks_scripts() method in the search widget. * Register jp-tracks dependency when registering jp-tracks-functions. Rename register function to destinguish it from the jptracks used in enqueue. Update register function to static to not instantiate class. Update dependencies to simplify only needed entries. * Update changelogger entry so Jetpack has changelog entry. * [not verified] Composer Updates to have dependency versions and meta as outlined by linting. Identity Crisis class has PACKAGE_VERSION attribute Update Identity Crisis to enqueue based on correct paths and versions. js file updated to have jsdocs, and updated var to let and const as appropriate. Webpack config updated to remove the polyfill that isn't required. Deleted rtl file that is auto-generated. * maintain current versions as we haven't switched to package aware * Update the register function to optionally enqueue. Necessary when other packages rely on the script but shouldn't be aware of file location details. * Update Sync Pakcage to have Identity_Crisis as a dependency. Update Sync Configure to call Identity_Crisis init Deprecation of Jetpack idc functions that are migrated to Identity Crisis package. Update Jetpack references to Identity Crisis. * Copy Admin.css to package (unblock Backup development. add _color.scss and color.scss to compare tool to ensure they remain aligned. composer version fix for wordbless. * reverse conditional so more intuitive. * Update references from Jetpack:: to Identity_Crisis for migrated methods. * remove tracks-callables.js from previous location. * remove migrated idc-notice.js file * Updated version using tools/project-version.sh * [not verified] Update dependency to proper versions. maintain class.jetpack-idc.php to avoid fatals during upgrade routines. Add proper use calls to files * Migrate home_url and site_url into Identity Crisis package to break dependency cycle. * remove Identity Crisis dependency on Sync. Migrate loading of IDC back to Jetpack. * missed update to Identity_Crisis/Functions from Sync/Functions * Fix typo and composer version. * proper package name jetpack-* * dependency updates to 1.22.x-dev for sync * tools/check-composer-deps.sh -u * Changelog update. * Update Status reference to deprecated class * Connection changelog * Updated the function check not the reference. * another round of dependency updates * Sync tests updated to use Identity_Functions * Another round of composer updates * More version dependency updates. * Changelog for jitm * Remove link idc-notice.js from exclude list. * update composer lock file * bump composer lock * Changelog * Migrate url functions into the Utils class of the Connection Package. * Missed update to callables, confirms our check for function exists is stopping fatals. * Update readme with instructions on how to initialize Identity Crisis flows. * Migration from Utils to Urls * Undo escapes, add PHPCS Update to use is_connected instead of deprecated is_active * Updated lock file * Missing use statement. * Build Assets should use require to get the array with version information. * Fix Build inclusion in mirror * Update docblock * remove contents of Jetpack_IDC class file * Update projects/packages/connection/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/identity-crisis/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update composer mismatch to 1.28.x-dev * Update Connection 1.28 dependency and lock * Version updates to connection 1.28 * Backup composer lock * Changelog and lock file updates Co-authored-by: Brad Jorsch <brad.jorsch@automattic.com> Co-authored-by: Sergey Mitroshin <sergeymitr@gmail.com> Co-authored-by: Brandon Kraft <public@brandonkraft.com> Co-authored-by: Matthew Denton <matt@mdbitz.com> Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/879621148
* Initial skeleton for the Identity_Crisis package. Including the basic file and class structures for now. * Adding the initial version of the Identity_Crisis class copied from the Jetpack_IDC class. A lot of the code has been massaged/fixed to pass the phpcs checks. * Finally getting some of the dependencies resolved. The phpunit tests will actually run now. * Resolving the remaining Jetpack class dependencies. The methods used have all been copied to the Identity_Crisis class. * Updating the readme's usage section. * Making some changes to use the new Identity_Crisis package. Removing the old Jetpack_IDC class. * Adding the password-checker package back after rebase. * removing the identity-crisis package so that I can rebase. * Adding the identity-crisis package back after rebase. * Adding changelog entry. * Adding the changelogger package. * Adding changelog entry. * Removing the identity-crisis package directory. Should avoid a merge confict later on. * Removing the identity-crisis package so that I can rebase. * Adding changelog entry * Adding the identity-crisis package back after rebase. * Adding the idc-notice.js asset. * Adding tooling to handle building assets. * Adding a few other files I missed in the last commit. * Bumping the node version to 14. Adding the identity-crisis package to the Monorepo packages ignore list. * Building JS. * Adding the CSS assets. * Building SCSS * Adjust enqueueing of the built assets. * Adding CSS assets for jetpack-idc-admin-bar and jetpack-idc-admin-bar-rtl. * Adding the tracks-callables.js file to the Tracking package. Related: Automattic/jetpack#15929 * Adding changelog entry. * Adding the Tracking package. Using the Tracking package's enqueue_tracks_scripts() method to handle the JS assets. * Removing the calls to wp_register_script() for the tracks-callable.js file. Removing the jp-tracks-functions slug from the array of script slugs. * Adding changelog entry. * Reverting the changes to class.jetpack.php. It seems we'll still need to enqueue the scripts here. * Adding the register_tracks_scripts() method. This will handle calling the wp_register_script() function for the tracks-callables.js file. In the class.jetpack.php file, replacing the call to the wp_register_script() function with the $tracking->register_tracks_scripts() method. * Call the new register_tracks_scripts() method that will soon exist in the Tracking package. * Calling the $tracking->register_tracks_scripts() method in the search widget. * Register jp-tracks dependency when registering jp-tracks-functions. Rename register function to destinguish it from the jptracks used in enqueue. Update register function to static to not instantiate class. Update dependencies to simplify only needed entries. * Update changelogger entry so Jetpack has changelog entry. * [not verified] Composer Updates to have dependency versions and meta as outlined by linting. Identity Crisis class has PACKAGE_VERSION attribute Update Identity Crisis to enqueue based on correct paths and versions. js file updated to have jsdocs, and updated var to let and const as appropriate. Webpack config updated to remove the polyfill that isn't required. Deleted rtl file that is auto-generated. * maintain current versions as we haven't switched to package aware * Update the register function to optionally enqueue. Necessary when other packages rely on the script but shouldn't be aware of file location details. * Update Sync Pakcage to have Identity_Crisis as a dependency. Update Sync Configure to call Identity_Crisis init Deprecation of Jetpack idc functions that are migrated to Identity Crisis package. Update Jetpack references to Identity Crisis. * Copy Admin.css to package (unblock Backup development. add _color.scss and color.scss to compare tool to ensure they remain aligned. composer version fix for wordbless. * reverse conditional so more intuitive. * Update references from Jetpack:: to Identity_Crisis for migrated methods. * remove tracks-callables.js from previous location. * remove migrated idc-notice.js file * Updated version using tools/project-version.sh * [not verified] Update dependency to proper versions. maintain class.jetpack-idc.php to avoid fatals during upgrade routines. Add proper use calls to files * Migrate home_url and site_url into Identity Crisis package to break dependency cycle. * remove Identity Crisis dependency on Sync. Migrate loading of IDC back to Jetpack. * missed update to Identity_Crisis/Functions from Sync/Functions * Fix typo and composer version. * proper package name jetpack-* * dependency updates to 1.22.x-dev for sync * tools/check-composer-deps.sh -u * Changelog update. * Update Status reference to deprecated class * Connection changelog * Updated the function check not the reference. * another round of dependency updates * Sync tests updated to use Identity_Functions * Another round of composer updates * More version dependency updates. * Changelog for jitm * Remove link idc-notice.js from exclude list. * update composer lock file * bump composer lock * Changelog * Migrate url functions into the Utils class of the Connection Package. * Missed update to callables, confirms our check for function exists is stopping fatals. * Update readme with instructions on how to initialize Identity Crisis flows. * Migration from Utils to Urls * Undo escapes, add PHPCS Update to use is_connected instead of deprecated is_active * Updated lock file * Missing use statement. * Build Assets should use require to get the array with version information. * Fix Build inclusion in mirror * Update docblock * remove contents of Jetpack_IDC class file * Update projects/packages/connection/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/identity-crisis/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update composer mismatch to 1.28.x-dev * Update Connection 1.28 dependency and lock * Version updates to connection 1.28 * Backup composer lock * Changelog and lock file updates Co-authored-by: Brad Jorsch <brad.jorsch@automattic.com> Co-authored-by: Sergey Mitroshin <sergeymitr@gmail.com> Co-authored-by: Brandon Kraft <public@brandonkraft.com> Co-authored-by: Matthew Denton <matt@mdbitz.com> Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/879621148
* Initial skeleton for the Identity_Crisis package. Including the basic file and class structures for now. * Adding the initial version of the Identity_Crisis class copied from the Jetpack_IDC class. A lot of the code has been massaged/fixed to pass the phpcs checks. * Finally getting some of the dependencies resolved. The phpunit tests will actually run now. * Resolving the remaining Jetpack class dependencies. The methods used have all been copied to the Identity_Crisis class. * Updating the readme's usage section. * Making some changes to use the new Identity_Crisis package. Removing the old Jetpack_IDC class. * Adding the password-checker package back after rebase. * removing the identity-crisis package so that I can rebase. * Adding the identity-crisis package back after rebase. * Adding changelog entry. * Adding the changelogger package. * Adding changelog entry. * Removing the identity-crisis package directory. Should avoid a merge confict later on. * Removing the identity-crisis package so that I can rebase. * Adding changelog entry * Adding the identity-crisis package back after rebase. * Adding the idc-notice.js asset. * Adding tooling to handle building assets. * Adding a few other files I missed in the last commit. * Bumping the node version to 14. Adding the identity-crisis package to the Monorepo packages ignore list. * Building JS. * Adding the CSS assets. * Building SCSS * Adjust enqueueing of the built assets. * Adding CSS assets for jetpack-idc-admin-bar and jetpack-idc-admin-bar-rtl. * Adding the tracks-callables.js file to the Tracking package. Related: Automattic/jetpack#15929 * Adding changelog entry. * Adding the Tracking package. Using the Tracking package's enqueue_tracks_scripts() method to handle the JS assets. * Removing the calls to wp_register_script() for the tracks-callable.js file. Removing the jp-tracks-functions slug from the array of script slugs. * Adding changelog entry. * Reverting the changes to class.jetpack.php. It seems we'll still need to enqueue the scripts here. * Adding the register_tracks_scripts() method. This will handle calling the wp_register_script() function for the tracks-callables.js file. In the class.jetpack.php file, replacing the call to the wp_register_script() function with the $tracking->register_tracks_scripts() method. * Call the new register_tracks_scripts() method that will soon exist in the Tracking package. * Calling the $tracking->register_tracks_scripts() method in the search widget. * Register jp-tracks dependency when registering jp-tracks-functions. Rename register function to destinguish it from the jptracks used in enqueue. Update register function to static to not instantiate class. Update dependencies to simplify only needed entries. * Update changelogger entry so Jetpack has changelog entry. * [not verified] Composer Updates to have dependency versions and meta as outlined by linting. Identity Crisis class has PACKAGE_VERSION attribute Update Identity Crisis to enqueue based on correct paths and versions. js file updated to have jsdocs, and updated var to let and const as appropriate. Webpack config updated to remove the polyfill that isn't required. Deleted rtl file that is auto-generated. * maintain current versions as we haven't switched to package aware * Update the register function to optionally enqueue. Necessary when other packages rely on the script but shouldn't be aware of file location details. * Update Sync Pakcage to have Identity_Crisis as a dependency. Update Sync Configure to call Identity_Crisis init Deprecation of Jetpack idc functions that are migrated to Identity Crisis package. Update Jetpack references to Identity Crisis. * Copy Admin.css to package (unblock Backup development. add _color.scss and color.scss to compare tool to ensure they remain aligned. composer version fix for wordbless. * reverse conditional so more intuitive. * Update references from Jetpack:: to Identity_Crisis for migrated methods. * remove tracks-callables.js from previous location. * remove migrated idc-notice.js file * Updated version using tools/project-version.sh * [not verified] Update dependency to proper versions. maintain class.jetpack-idc.php to avoid fatals during upgrade routines. Add proper use calls to files * Migrate home_url and site_url into Identity Crisis package to break dependency cycle. * remove Identity Crisis dependency on Sync. Migrate loading of IDC back to Jetpack. * missed update to Identity_Crisis/Functions from Sync/Functions * Fix typo and composer version. * proper package name jetpack-* * dependency updates to 1.22.x-dev for sync * tools/check-composer-deps.sh -u * Changelog update. * Update Status reference to deprecated class * Connection changelog * Updated the function check not the reference. * another round of dependency updates * Sync tests updated to use Identity_Functions * Another round of composer updates * More version dependency updates. * Changelog for jitm * Remove link idc-notice.js from exclude list. * update composer lock file * bump composer lock * Changelog * Migrate url functions into the Utils class of the Connection Package. * Missed update to callables, confirms our check for function exists is stopping fatals. * Update readme with instructions on how to initialize Identity Crisis flows. * Migration from Utils to Urls * Undo escapes, add PHPCS Update to use is_connected instead of deprecated is_active * Updated lock file * Missing use statement. * Build Assets should use require to get the array with version information. * Fix Build inclusion in mirror * Update docblock * remove contents of Jetpack_IDC class file * Update projects/packages/connection/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/identity-crisis/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update composer mismatch to 1.28.x-dev * Update Connection 1.28 dependency and lock * Version updates to connection 1.28 * Backup composer lock * Changelog and lock file updates Co-authored-by: Brad Jorsch <brad.jorsch@automattic.com> Co-authored-by: Sergey Mitroshin <sergeymitr@gmail.com> Co-authored-by: Brandon Kraft <public@brandonkraft.com> Co-authored-by: Matthew Denton <matt@mdbitz.com> Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/879621148
* Initial skeleton for the Identity_Crisis package. Including the basic file and class structures for now. * Adding the initial version of the Identity_Crisis class copied from the Jetpack_IDC class. A lot of the code has been massaged/fixed to pass the phpcs checks. * Finally getting some of the dependencies resolved. The phpunit tests will actually run now. * Resolving the remaining Jetpack class dependencies. The methods used have all been copied to the Identity_Crisis class. * Updating the readme's usage section. * Making some changes to use the new Identity_Crisis package. Removing the old Jetpack_IDC class. * Adding the password-checker package back after rebase. * removing the identity-crisis package so that I can rebase. * Adding the identity-crisis package back after rebase. * Adding changelog entry. * Adding the changelogger package. * Adding changelog entry. * Removing the identity-crisis package directory. Should avoid a merge confict later on. * Removing the identity-crisis package so that I can rebase. * Adding changelog entry * Adding the identity-crisis package back after rebase. * Adding the idc-notice.js asset. * Adding tooling to handle building assets. * Adding a few other files I missed in the last commit. * Bumping the node version to 14. Adding the identity-crisis package to the Monorepo packages ignore list. * Building JS. * Adding the CSS assets. * Building SCSS * Adjust enqueueing of the built assets. * Adding CSS assets for jetpack-idc-admin-bar and jetpack-idc-admin-bar-rtl. * Adding the tracks-callables.js file to the Tracking package. Related: Automattic/jetpack#15929 * Adding changelog entry. * Adding the Tracking package. Using the Tracking package's enqueue_tracks_scripts() method to handle the JS assets. * Removing the calls to wp_register_script() for the tracks-callable.js file. Removing the jp-tracks-functions slug from the array of script slugs. * Adding changelog entry. * Reverting the changes to class.jetpack.php. It seems we'll still need to enqueue the scripts here. * Adding the register_tracks_scripts() method. This will handle calling the wp_register_script() function for the tracks-callables.js file. In the class.jetpack.php file, replacing the call to the wp_register_script() function with the $tracking->register_tracks_scripts() method. * Call the new register_tracks_scripts() method that will soon exist in the Tracking package. * Calling the $tracking->register_tracks_scripts() method in the search widget. * Register jp-tracks dependency when registering jp-tracks-functions. Rename register function to destinguish it from the jptracks used in enqueue. Update register function to static to not instantiate class. Update dependencies to simplify only needed entries. * Update changelogger entry so Jetpack has changelog entry. * [not verified] Composer Updates to have dependency versions and meta as outlined by linting. Identity Crisis class has PACKAGE_VERSION attribute Update Identity Crisis to enqueue based on correct paths and versions. js file updated to have jsdocs, and updated var to let and const as appropriate. Webpack config updated to remove the polyfill that isn't required. Deleted rtl file that is auto-generated. * maintain current versions as we haven't switched to package aware * Update the register function to optionally enqueue. Necessary when other packages rely on the script but shouldn't be aware of file location details. * Update Sync Pakcage to have Identity_Crisis as a dependency. Update Sync Configure to call Identity_Crisis init Deprecation of Jetpack idc functions that are migrated to Identity Crisis package. Update Jetpack references to Identity Crisis. * Copy Admin.css to package (unblock Backup development. add _color.scss and color.scss to compare tool to ensure they remain aligned. composer version fix for wordbless. * reverse conditional so more intuitive. * Update references from Jetpack:: to Identity_Crisis for migrated methods. * remove tracks-callables.js from previous location. * remove migrated idc-notice.js file * Updated version using tools/project-version.sh * [not verified] Update dependency to proper versions. maintain class.jetpack-idc.php to avoid fatals during upgrade routines. Add proper use calls to files * Migrate home_url and site_url into Identity Crisis package to break dependency cycle. * remove Identity Crisis dependency on Sync. Migrate loading of IDC back to Jetpack. * missed update to Identity_Crisis/Functions from Sync/Functions * Fix typo and composer version. * proper package name jetpack-* * dependency updates to 1.22.x-dev for sync * tools/check-composer-deps.sh -u * Changelog update. * Update Status reference to deprecated class * Connection changelog * Updated the function check not the reference. * another round of dependency updates * Sync tests updated to use Identity_Functions * Another round of composer updates * More version dependency updates. * Changelog for jitm * Remove link idc-notice.js from exclude list. * update composer lock file * bump composer lock * Changelog * Migrate url functions into the Utils class of the Connection Package. * Missed update to callables, confirms our check for function exists is stopping fatals. * Update readme with instructions on how to initialize Identity Crisis flows. * Migration from Utils to Urls * Undo escapes, add PHPCS Update to use is_connected instead of deprecated is_active * Updated lock file * Missing use statement. * Build Assets should use require to get the array with version information. * Fix Build inclusion in mirror * Update docblock * remove contents of Jetpack_IDC class file * Update projects/packages/connection/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/identity-crisis/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/changelog/update-use-identity-crisis-package Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/plugins/jetpack/class.jetpack.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update projects/packages/sync/src/class-functions.php Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> * Update composer mismatch to 1.28.x-dev * Update Connection 1.28 dependency and lock * Version updates to connection 1.28 * Backup composer lock * Changelog and lock file updates Co-authored-by: Brad Jorsch <brad.jorsch@automattic.com> Co-authored-by: Sergey Mitroshin <sergeymitr@gmail.com> Co-authored-by: Brandon Kraft <public@brandonkraft.com> Co-authored-by: Matthew Denton <matt@mdbitz.com> Co-authored-by: Brad Jorsch <anomiex@users.noreply.github.com> Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/879621148
As I am reviewing Tracks PRs, it makes me realize that we should probably do an iteration on some of those libs, to consolidate things and ensure everything is well documented and that the Tracking package has all the info one would need to use it.
We currently have quite a few solutions available to contributors:
_inc/client/lib/analytics/
for the React dashboard. Maybe we should work with the Calypso team to move to using a package from the Calypso monorepo if possible. That would ensure we get the latest fixes and enhancements made to that tool. As far as I can tell Calypso's implementation is not a package yet (although we have Calypso Analytics), but I see that @sgomes has been working on the lib lately, so he may have some insight there._inc/lib/tracks/tracks-callables.js
for a port of the React implementation._inc/lib/tracks/tracks-ajax.js
for the Ajax implementation used in the Tracking package (maybe the lib should be part of the package?).src/class-tracking.php
for the implementation of the Tracking package within the Jetpack plugin.None of those solutions are really well documented, so this can be a bit confusing. Maybe we could revisit this and look at all uses of Tracking within the plugin to ensure every feature uses the correct solution.
The text was updated successfully, but these errors were encountered: