Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact Form: add submitted date to entries in feedback csv file #2169

Closed
richardfrench opened this issue May 25, 2015 · 14 comments
Closed

Contact Form: add submitted date to entries in feedback csv file #2169

richardfrench opened this issue May 25, 2015 · 14 comments
Labels
[Feature] Contact Form Good For Community [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Milestone

Comments

@richardfrench
Copy link

Feedback when exported as CSV has no date information for each entry. I think this would be a useful feature. I can create a patch for this, but wondered if adding a date should be optional or not, depending on an option within the Feedback page.

@georgestephanis
Copy link
Member

I'm not sure if there would be any danger in silently changing the csv format -- if anyone has built things on top of it that read it in and wouldn't know what to do with the new column. I'm certainly up to consider it though, just that we may need to add a way to let folks use a filter to strip it back out.

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Contact Form labels May 25, 2015
@jeherve jeherve added this to the vFuture milestone May 25, 2015
@jeherve jeherve changed the title Add submitted date to entries in feedback csv file Contact Form: add submitted date to entries in feedback csv file May 25, 2015
@samhotchkiss samhotchkiss modified the milestones: vFuture, Needs Triage Aug 29, 2015
@jeherve jeherve modified the milestones: Community, Needs Triage Dec 13, 2015
@jeherve
Copy link
Member

jeherve commented Jan 20, 2017

Closing this for now because of the lack of activity on this. We can always reopen in the future if needed.

@jeherve jeherve closed this as completed Jan 20, 2017
@formosattic
Copy link

formosattic commented Jul 14, 2017

Requested in 3322426-t.

Outdated plugin which could export with date: https://wordpress.org/plugins/jetpack-feedback-exporter/. Tested it but did not manage to get it working.

@seejacobscott
Copy link

Requested in 760204-zen.

This does seem like important info to include on an export, especially if there is a large amount of feedback that is exported. Reopening for now.

@seejacobscott seejacobscott reopened this Oct 28, 2017
@airdrummer
Copy link
Contributor

thanx, jacob

@airdrummer
Copy link
Contributor

i imagine the date can be added in function get_post_meta_for_csv_export()

@jeherve jeherve removed this from the Community milestone Oct 30, 2017
@stale
Copy link

stale bot commented Sep 17, 2018

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Sep 17, 2018
@richardmtl
Copy link
Contributor

@stale stale bot removed the [Status] Stale label Oct 12, 2018
@stale
Copy link

stale bot commented Apr 10, 2019

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Apr 10, 2019
@airdrummer
Copy link
Contributor

why has this been dropped? feedback date is a primary data point ffs:-\

@stale stale bot removed the [Status] Stale label Dec 29, 2019
@airdrummer
Copy link
Contributor

airdrummer commented Dec 31, 2019

in modules/contact-form/grunion-contact-form.php

854,860c854,855
< 	public function get_post_meta_for_csv_export( $post_id ) 
< 	{
< 		$md = get_post_meta( $post_id, '_feedback_extra_fields', true );
< 		$md['feedback_date'] = get_the_date( 'Y-m-d H:i:sT', $post_id );
<  	    $content_fields = Grunion_Contact_Form_Plugin::parse_fields_from_content( $post_id );
< 	    $md['feedback_ip'] = $content_fields['_feedback_ip'];
< 		return $md;
---
> 	public function get_post_meta_for_csv_export( $post_id ) {
> 		return get_post_meta( $post_id, '_feedback_extra_fields', true );

@jeherve
Copy link
Member

jeherve commented Jan 6, 2020

@airdrummer Feel free to open a Pull Request with your changes, we'll be happy to review them!

@airdrummer
Copy link
Contributor

sorry i last used git 10yrs ago & don't have time to set up a dev env

@htdat
Copy link
Member

htdat commented Jan 14, 2020

Should be fixed in #14304

@htdat htdat closed this as completed Jan 14, 2020
@jeherve jeherve added this to the 8.2 milestone Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Contact Form Good For Community [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

No branches or pull requests

9 participants