Contact Form: Add IP & date to CSV Export

[airdrummer]

Fixes #
Changes proposed in this Pull Request:

add feedback ip & date to csv export

Testing instructions:

Start with a connected Jetpack site.
Add a Contact Form in the usual manner - block or classic editor.
Add 4-5 contact form responses.
Export via CSV by going to wp-admin, Feedback-> Export
Open the CSV and confirm the date/IP are included.

Proposed changelog entry for your changes:

add feedback ip & date to csv export

[jetpackbot]

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 14, 2020.
Scheduled code freeze: January 7, 2020

Generated by 🚫 dangerJS against fae73a3

[jeherve]

Thanks for the contribution. Unit Tests are currently failing with your change:

1) WP_Test_Grunion_Contact_Form::test_personal_data_exporter
has total expected data keys
Failed asserting that 8 is identical to 6.
/tmp/wordpress-latest/src/wp-content/plugins/jetpack/tests/php/modules/contact-form/test-class.grunion-contact-form.php:1405

You'll consequently need to update the test to take your changes into account.

Could you also add testing instructions to your Pull Request's description?

Thank you!

[airdrummer]

ok, fixed test...not sure about instructions

[kraftbj]

Thanks @airdrummer. With instructions, they don't need to be complex, but something like:

1. Start with a connected Jetpack site.
2. Add a Contact Form in the usual manner - block or classic editor.
3. Add 4-5 contact form responses.
4. Export via CSV by going to wp-admin, Feedback-> XYZ
5. Open the CSV and confirm the date/IP are included.

Enough so a reviewer can know the expected path on exposing the new feature.

[airdrummer]

ok, thanx, kraftbj...not sure if my hacks r the most efficient way to add ip & datestamp, and my definition of metadata seems 2 b different from wordpress's;-} but it fixes a severe deficiency in export.

curiously, if you have 2 different contact forms & export separately, the field order is reversed but idk as long as the metadata is complete;-)

[kraftbj]

Pushed up a commit to fix the PHPCS violations.

[kraftbj]

A couple more minor things that I added suggestions for, but I think we can aim to land this in 8.2.

[jeherve]

This seems to test well for me. 👍

[matticbot]

Caution: This PR has changes that must be merged to WordPress.com
Hello airdrummer! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D37523-code before merging this PR. Thank you!

[kraftbj]

201495-wpcom