Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learn more vs (i) new window behavior #6908

Closed
beaulebens opened this issue Apr 4, 2017 · 1 comment · Fixed by #12301
Closed

Learn more vs (i) new window behavior #6908

beaulebens opened this issue Apr 4, 2017 · 1 comment · Fixed by #12301
Labels
Admin Page React-powered dashboard under the Jetpack menu [Pri] Low [Status] Needs Design Review Design has been added. Needs a review! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Milestone

Comments

@beaulebens
Copy link
Member

Currently, we have both inline "Learn more" text links, and (i) icons, which contain Learn more links.

screen shot 2017-04-04 at 3 30 19 pm
screen shot 2017-04-04 at 3 30 15 pm

#6850 will add some brief text to the (i) icons, but we should be consistent with what does and doesn't open a new window. Inline "Learn more" links do not open a new window, but "Learn more" links within the (i) bubbles do open a new window.

Let's pick one, and standardize on it.

@dereksmart dereksmart added [Status] Needs Design Review Design has been added. Needs a review! Admin Page React-powered dashboard under the Jetpack menu [Pri] Low labels Apr 5, 2017
@brbrr brbrr added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Jun 13, 2018
@stale
Copy link

stale bot commented Dec 10, 2018

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Pri] Low [Status] Needs Design Review Design has been added. Needs a review! [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants