Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any given plugin erroring or adding warning messages to the output forbids the user to connect Jetpack from wp-admin #7979

Closed
oskosk opened this issue Oct 12, 2017 · 0 comments
Assignees
Labels
Admin Page React-powered dashboard under the Jetpack menu [Pri] High [Type] Bug When a feature is broken and / or not performing as intended

Comments

@oskosk
Copy link
Contributor

oskosk commented Oct 12, 2017

The Connect buttons that Jetpack adds to wp-admin (notices and the Jetpack Admin page) rely on a call to the plugin's REST API for fetching the connection URL. If any given plugin is erroring or adding messages to the output, this will make the connect URLs be wrong and thus the buttons won't work.

Steps to reproduce the issue

  1. Have a disconnected site
  2. Edit something to echo a string anywhere.
  3. Reach the Jetpack admin page.
  4. Click the "Connect Jetpack" button
  5. expect a 404 or something similar

What I expected

I expected that not to happen but it's fine. It can be circumvented somehow.

What happened instead

Wasn't able to connect my Jetpack

@oskosk oskosk added the [Type] Bug When a feature is broken and / or not performing as intended label Oct 12, 2017
@jeherve jeherve added Admin Page React-powered dashboard under the Jetpack menu [Pri] High labels Oct 13, 2017
@oskosk oskosk self-assigned this Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Pri] High [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

2 participants