Connect Button: Malformed href.

[georgestephanis]

When viewing the connect button, the markup looks something like this:

<div data-reactid=".0.0.1.2.0.1.2:1">
<noscript data-reactid=".0.0.1.2.0.1.2:1.0"></noscript>
<a href="&amp;from=landing-page-top" type="button" class="is-primary jp-jetpack-connect__button dops-button" data-reactid=".0.0.1.2.0.1.2:1.1">Connect Jetpack</a>
<noscript data-reactid=".0.0.1.2.0.1.2:1.2"></noscript>
</div>

Specifically the href="&from=landing-page-top" bit is caused by this code here:

jetpack/_inc/client/components/connect-button/index.jsx

Lines 119 to 122 in ec47f76

	let connectUrl = this.props.connectUrl;
	if ( this.props.from ) {
	connectUrl += `&from=${ this.props.from }`;
	}

being triggered by

jetpack/_inc/client/components/jetpack-connect/index.jsx

Line 32 in ec47f76

<ConnectButton from="landing-page-top">

There is no this.props.connectUrl specified, so the link appends &from=${ this.props.from } onto an empty variable, resulting in the malformed href.

Steps to reproduce the issue

Visit the connect page and inspect the button.

What I expected

A valid url in the href attribute.

What happened instead

A malformed url.

[georgestephanis]

I'm investigating further -- this may actually be not an issue.

[oskosk]

@georgestephanis this seems related: #7979

[georgestephanis]

I'm running a distclean and reinstall right now.

Also this is in a multisite install, so that could potentially affect it as well.

Checking ...

[oskosk]

is it subdomain based multisite or subdir-based ?

[georgestephanis]

subdomain

[oskosk]

fwiw, when visiting the Jetpack admin page, there should be a background request to the plugin's rest endpoint /connection/url. If the response of that endpoint is not a single string between quotes, then there's a problem similar to the one reported in 7979.

[georgestephanis]

Nevermind, this was a duplicate of an unrelated thing I was working on -- https://wordpress.org/support/topic/domain-mapping-connect-issue/

The rest api endpoints weren't queryable because of the wpmu domain mapping plugin.