-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connect Button: Malformed href. #7988
Comments
I'm investigating further -- this may actually be not an issue. |
@georgestephanis this seems related: #7979 |
I'm running a distclean and reinstall right now. Also this is in a multisite install, so that could potentially affect it as well. Checking ... |
is it subdomain based multisite or subdir-based ? |
subdomain |
fwiw, when visiting the Jetpack admin page, there should be a background request to the plugin's rest endpoint |
Nevermind, this was a duplicate of an unrelated thing I was working on -- https://wordpress.org/support/topic/domain-mapping-connect-issue/ The rest api endpoints weren't queryable because of the wpmu domain mapping plugin. |
When viewing the connect button, the markup looks something like this:
Specifically the
href="&from=landing-page-top"
bit is caused by this code here:jetpack/_inc/client/components/connect-button/index.jsx
Lines 119 to 122 in ec47f76
being triggered by
jetpack/_inc/client/components/jetpack-connect/index.jsx
Line 32 in ec47f76
There is no
this.props.connectUrl
specified, so the link appends&from=${ this.props.from }
onto an empty variable, resulting in the malformed href.Steps to reproduce the issue
Visit the connect page and inspect the button.
What I expected
A valid url in the href attribute.
What happened instead
A malformed url.
The text was updated successfully, but these errors were encountered: