Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search: Can't disable search module if search widget is active #8929

Closed
Viper007Bond opened this issue Feb 23, 2018 · 0 comments · Fixed by #8931
Closed

Search: Can't disable search module if search widget is active #8929

Viper007Bond opened this issue Feb 23, 2018 · 0 comments · Fixed by #8931
Assignees
@Viper007Bond
Labels
[Feature] Search For all things related to Search [Type] Bug When a feature is broken and / or not performing as intended
Milestone
5.9

Comments

@Viper007Bond
Copy link
Contributor

A side effect of #8822, if you have the widget in your sidebar (or wherever), then you can't disable the search module.

We need to hook into the deactivate module code and move the widget to the inactive area.
@Viper007Bond Viper007Bond added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Search For all things related to Search labels Feb 23, 2018
@Viper007Bond Viper007Bond added this to the 5.9 milestone Feb 23, 2018
@Viper007Bond Viper007Bond self-assigned this Feb 23, 2018
@Viper007Bond Viper007Bond mentioned this issue Feb 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Viper007Bond Viper007Bond

Labels
[Feature] Search For all things related to Search [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
5.9
1 participant
@Viper007Bond