Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: When disabling the search module, move any active search widgets to the inactive list. #8931

Merged
merged 1 commit into from
Feb 26, 2018

Conversation

Viper007Bond
Copy link
Contributor

@Viper007Bond Viper007Bond commented Feb 23, 2018

Fixes #8929

Changes proposed in this Pull Request:

Due to #8822, having the search widget active will enable the search module. This makes it impossible to disable the module while the widget is in use.

This change moves any active search widgets to the inactive list if you disable the search module.

Testing instructions:

  1. Add the Jetpack Search widget to your sidebar. Ideally give it a custom title so you can more easily track it.
  2. Disable the search module.
  3. Refresh the page and verify that the search module is still disabled.
  4. Visit the widgets configuration page and make sure that the widget you added in step one is now listed at the top of the inactive widgets list.

Changelog entry

Move any active search widgets to the inactive list if you disable the search module.

@Viper007Bond Viper007Bond added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Search For all things related to Search labels Feb 23, 2018
@Viper007Bond Viper007Bond added this to the 5.9 milestone Feb 23, 2018
@Viper007Bond Viper007Bond self-assigned this Feb 23, 2018
@jeherve jeherve added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Feb 24, 2018
@Viper007Bond Viper007Bond requested a review from a team February 26, 2018 23:38
Copy link
Member

@gibrown gibrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM. I tested deactivation with both the Jetpack dashboard settings and also from Calypso. Worked on both.

@Viper007Bond Viper007Bond merged commit 1ab21c7 into master Feb 26, 2018
@Viper007Bond Viper007Bond deleted the fix/search/deactive-widget-on-module-disable branch February 26, 2018 23:54
oskosk added a commit that referenced this pull request Feb 27, 2018
oskosk added a commit that referenced this pull request Feb 27, 2018
* update changelog.txt

* Update readme.txt with scaffolding for 5.9 changelog and release draft shortlink

* Add changelog entry for #8243

* Add changelog entry for #8296

* Add changelog entry for #8367

* Add changelog entry for #8686

* Add changelog entry for #8707

* Add changelog entry for #8709 and #8714

* Add changelog entry for #8729

* Add changelog entry for #8777

* Add changelog entry for #8780

* Add changelog entry for #8786

* Add changelog entry for #8787

* Add changelog entry for #8801 #8805 #8832 #8865 and #8804

* Add changelog entry for #8817

* Add changelog entry for #8822

* Add changelog entry for #8823

* Add changelog entry for #8829

* Add changelog entry for #8834

* move some items to major enhancements

* Add changelog entry for #8836

* Add changelog entry for #8839

* Add changelog entry for #8861

* Add changelog entry for #8862

* Add changelog entry for #8863

* Add changelog entry for #8866

* Add changelog entry for #8870

* Add changelog entry for #8874

* Add changelog entry for #8875

* Add changelog entry for #8881

* Add changelog entry for #8890

* Add changelog entry for #8911

* Add changelog entry for #8927

* Add changelog entry for #8931

* Add changelog entry for #8933

* Add changelog entry for #8930

* fix wording

* typo

* minor fixes

* replace partner scripts for Jetpack Start in changelog entry

* Update to-test.md

* Update to-test.md

* minor style fixes to to-test.md

* minor style fixes to to-test.md

* minor fixes on to-test.md

* Add changelog entry for #8868

* Add changelog entry for #8844

* Add changelog entry for #8664

* Add changelog entry for #8935

* Add changelog entry for #8425

* Add changelog entry for #8625
@kraftbj kraftbj removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Search For all things related to Search Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search: Can't disable search module if search widget is active
6 participants