Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Youtube Shortcode: Updates regex #10224

Merged
merged 3 commits into from
Dec 3, 2018
Merged

Youtube Shortcode: Updates regex #10224

merged 3 commits into from
Dec 3, 2018

Commits on Dec 3, 2018

  1. Youtube Shortcode: Updates regex 

    Brings upstream changes from wp.com discussed in D17568-code and D17868-code.
    @kraftbj @jeherve
    kraftbj authored and jeherve committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    eb9b2cb View commit details
    Browse the repository at this point in the history

  2. Improve the matching of the youtube shortcode reversal again. 

    Merges r184358-wpcom

In D17568-code and D17868-code we improved this code.
Those changes accidentally got reversed in D18511-code
I was reviewing #10224 which would merge the original
changes into Jetpack and noted the 's' modifier.
Unfortunately we can't include that here because it means on long but malformed post content we go into an
infinite loop because of the .*? in the RegEx.
This means we can't match objects/mangled objects which have a newline within them but we can match more
that we were

Diff: D21652-code
    @westi @jeherve
    westi authored and jeherve committed Dec 3, 2018
    1 Configuration menu
    Copy the full SHA
    e4c966d View commit details
    Browse the repository at this point in the history

  3. YouTube: escape . characters when matching Youtube.com 

    @see #10224 (comment)
    @andfinally @jeherve
    andfinally authored and jeherve committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    d3bd4ef View commit details
    Browse the repository at this point in the history