Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg: add dependencies for Tiled gallery block #10302

Merged
merged 2 commits into from
Oct 12, 2018
Merged

Gutenberg: add dependencies for Tiled gallery block #10302

merged 2 commits into from
Oct 12, 2018

Conversation

simison
Copy link
Member

@simison simison commented Oct 11, 2018 •
edited
Loading

Add two Gutenberg core dependencies for Tiled Gallery block:

  • Keycodes (see where it's used)
    • Used e.g. to remove image from the gallery when image is selected and pressing backspace.
  • Token-list (see where it's used)
    • Used to parse CSS classes when switching alternate block styles

Testing instructions:

@simison simison added [Status] In Progress [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Oct 11, 2018
@simison simison self-assigned this Oct 11, 2018
@jetpackbot
Copy link

Warnings
⚠️

"Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is automated check which relies on PULL_REQUEST_TEMPLATE.We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS

@jeherve jeherve added this to the 6.7 milestone Oct 11, 2018
@simison simison mentioned this pull request Oct 12, 2018
Merged
@simison simison requested a review from a team October 12, 2018 08:43
@simison simison added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] In Progress labels Oct 12, 2018
jeherve
jeherve approved these changes Oct 12, 2018
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work well! There are some issues with the Tiled Gallery block itself, but I assume it's because it's still under development.

@simison
Copy link
Member Author

simison commented Oct 12, 2018 •
edited
Loading

There are some issues with the Tiled Gallery block itself, but I assume it's because it's still under development.

Correct :-) (Automattic/wp-calypso#27458)

tyxla
tyxla approved these changes Oct 12, 2018
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Oct 12, 2018
@jeherve jeherve merged commit d3ed5de into master Oct 12, 2018
@jeherve jeherve deleted the update/gutenberg-deps-tiled-gallery branch October 12, 2018 13:26
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@tyxla tyxla tyxla approved these changes

Assignees

@simison simison

Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack
Projects
None yet
Milestone
6.7
Development

Successfully merging this pull request may close these issues.
5 participants
@simison @jetpackbot @jeherve @tyxla @matticbot