Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenpack: opt-in for beta blocks #10491

Merged
merged 5 commits into from
Oct 31, 2018
Merged

Gutenpack: opt-in for beta blocks #10491

merged 5 commits into from
Oct 31, 2018

Conversation

lezama
Copy link
Contributor

@lezama lezama commented Oct 30, 2018 •
edited
Loading

This PR will conditionally load Blocks in beta.

How to test

@lezama lezama added this to the 6.7 milestone Oct 30, 2018
@lezama lezama requested a review from a team October 30, 2018 17:39
@lezama lezama requested a review from a team as a code owner October 30, 2018 17:39
@jetpackbot
Copy link

Warnings
⚠️

"Testing instructions" are missing for this PR. Please add some
⚠️

"Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is automated check which relies on PULL_REQUEST_TEMPLATE.We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS

@enejb
Copy link
Member

enejb commented Oct 30, 2018

I was thinking about just loading a new files. But I think this is a better approach.
We need to document the filter but other then that I think it looks great!

enejb
enejb reviewed Oct 30, 2018
View reviewed changes
Copy link
Member

@enejb enejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other then the change and a calypso PR I think this approach is great!

class.jetpack-gutenberg.php Outdated Show resolved Hide resolved
@dereksmart dereksmart added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Janitorial [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Oct 30, 2018
jeherve
jeherve approved these changes Oct 31, 2018
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work for now; I'll merge it. I would however recommend making more changes so we can ship a Beta 2 that would allow us to test frontend assets as well.

modules/tiled-gallery.php Show resolved Hide resolved
@jeherve jeherve merged commit a6af56f into master Oct 31, 2018
@jeherve jeherve deleted the add/optin-beta-blocks branch October 31, 2018 09:13
This was referenced Oct 31, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enejb enejb enejb left review comments

@jeherve jeherve jeherve approved these changes

Assignees
No one assigned
Labels
[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Type] Janitorial
Projects
None yet
Milestone
6.7
Development

Successfully merging this pull request may close these issues.
8 participants
@lezama @jetpackbot @enejb @jeherve @kraftbj @dereksmart @matticbot @roccotripaldi