Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Live Branches: Remove feature wordpress-5-beta from Jetpack Live Branches script #10850

Merged

Conversation

oskosk
Copy link
Contributor

@oskosk oskosk commented Dec 6, 2018

WordPress 5.0 is released on Friday December 6th 2018, we don't need this anymore. This feature will be also removed from Jurassic Ninja

Related: Automattic/jurassic.ninja#149

Changes proposed in this Pull Request:

  • Removes the ability to launch with a beta version of WordPress 5.0
  • Bumps Jetpack Live Branches script version to 1.8.

Testing instructions:

This is a straightforward change.

Proposed changelog entry for your changes:

  • None needed

WordPress 5.0 is released on Friday December 6th 2018
@oskosk oskosk added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Janitorial labels Dec 6, 2018
@oskosk oskosk requested a review from a team December 6, 2018 13:15
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 10, 2019.
Scheduled code freeze: January 3, 2019

Generated by 🚫 dangerJS

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Dec 6, 2018
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Merging.

@jeherve jeherve merged commit 22f9a68 into master Dec 6, 2018
@jeherve jeherve deleted the remove/wordpress-5-beta-feature-from-jetpack-live-branches branch December 6, 2018 13:21
@ghost ghost removed [Status] Needs Changelog [Status] Ready to Merge Go ahead, you can push that green button! labels Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants