Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection Banners: Add premium services to last slide #10867

Merged
merged 6 commits into from
Dec 13, 2018
Merged

Connection Banners: Add premium services to last slide #10867

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
db2ae85
Connection Banners: first commit. beginning to add new content
jeffgolenski Dec 7, 2018
76088ff
Connection banner: adding premium services content to last slide
jeffgolenski Dec 7, 2018
b04ff8d
connection banner: styling list. adding images
jeffgolenski Dec 7, 2018
568d068
Connection Banner: updates to verbiage
jeffgolenski Dec 8, 2018
84c52ba
Rename image file
keoshi Dec 13, 2018
7cf65bd
Take care of spaces and punctuation
keoshi Dec 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 37 additions & 16 deletions class.jetpack-connection-banner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ class="notice-dismiss connection-banner-dismiss"
<div class="vertical-menu__feature-item-icon">
<svg xmlns="http://www.w3.org/2000/svg" width="18" height="18" viewBox="0 4 15 15" version="1.1"><polygon points="6.6 4 6.6 10.6 0 10.6 0 12.4 6.6 12.4 6.6 19 8.4 19 8.4 12.4 15 12.4 15 10.6 8.4 10.6 8.4 4"/></svg>
</div>
<span class="vertical-menu__feature-item-label"><?php esc_html_e( 'More Features', 'jetpack' ); ?></span>
<span class="vertical-menu__feature-item-label"><?php esc_html_e( 'Premium Services', 'jetpack' ); ?></span>
</div>
</div>
</div>
Expand Down Expand Up @@ -452,12 +452,12 @@ class="dops-button is-primary">
<h2><?php esc_html_e( 'Faster performance and site speeds', 'jetpack' ); ?></h2>

<div class="jp-wpcom-connect__content-icon jp-connect-illo">
<img src="<?php echo esc_url( plugins_url( 'images/cloud-based.svg', JETPACK__PLUGIN_FILE ) ); ?>" alt="<?php
<img src="<?php echo esc_url( plugins_url( 'images/jetpack-speed.svg', JETPACK__PLUGIN_FILE ) ); ?>" alt="<?php
esc_attr_e(
'Activate Jetpack’s site accelerator to load pages faster, optimize your images, and serve your images and static files (like CSS and JavaScript) from our global network of servers. You’ll also reduce bandwidth usage, which may lead to lower hosting costs.',
'jetpack'
);
?>" height="auto" width="225" />
?>" height="auto" width="275" />
</div>

<p>
Expand Down Expand Up @@ -525,35 +525,56 @@ class="dops-button is-primary">
</p>
</div> <!-- end slide 5 -->

<!-- slide 6: more features -->
<!-- slide 6: premium services -->
<div class="jp-wpcom-connect__slide jp-wpcom-connect__slide-six">
<h2><?php esc_html_e( 'More Jetpack features our users love', 'jetpack' ) ?></h2>
<h2><?php esc_html_e( 'All the tools you&#8217;ll ever need for a more powerful WordPress site', 'jetpack' ) ?></h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to encode that apostrophe here. You can use ’.


<div class="jp-wpcom-connect__content-icon jp-connect-illo">
<img src="<?php echo plugins_url( 'images/customize-theme-2.svg', JETPACK__PLUGIN_FILE ); ?>" alt="<?php
<img src="<?php echo plugins_url( 'images/jetpack-poweringUp.svg', JETPACK__PLUGIN_FILE ); ?>" alt="<?php
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend that we stick to all lowercase, with - as separators, for file names. jetpack-powering-up.svg should be better.

esc_attr_e(
'Jetpack includes other features that help you customize your site',
'Jetpack premium services offer even more powerful performance, security, and revenue tools to help you keep your site safe, fast, and help generate income',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we try to have periods at the end of all those sentences?

'jetpack'
); ?>" height="auto" width="225" />
</div>

<p>
<?php
esc_html_e( 'Jetpack includes other features that help you customize your site including Custom CSS, Contact Forms, Galleries and Carousels, Notifications and Subscriptions, Configurable Widgets, and many more.',
esc_html_e( 'From hobbyists to large organizations — Jetpack Premium Services keep your site safer, faster, and help you earn more.',
'jetpack'
);
?>
</p>

<ul>
<li>
<strong><?php esc_html_e( 'Real-time automated backups & malware scanning:',
'jetpack'); ?></strong> <?php esc_html_e( ' Stay free of any hacking-related worries.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to have an extra space here.

'jetpack'); ?>
</li>
<li>
<strong><?php esc_html_e( 'Ad network:',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have an extra space here, and it seems there are more downer.

'jetpack'); ?></strong> <?php esc_html_e( ' Automatic approval to display ads that generate income from your traffic.',
'jetpack'); ?>
</li>
<li>
<strong><?php esc_html_e( 'Simple payment buttons:',
'jetpack'); ?></strong> <?php esc_html_e( ' Sell products on your site and accept instant PayPal payments.',
'jetpack'); ?>
</li>
<li>
<strong><?php esc_html_e( 'Enhanced search:',
'jetpack'); ?></strong> <?php esc_html_e( ' A WordPress search tool that gives readers faster and more relevant results.',
'jetpack'); ?>
</li>
<li>
<strong><?php esc_html_e( 'Priority support & concierge setup:',
'jetpack'); ?></strong> <?php esc_html_e( ' A one-on-one session to get the most out of your Jetpack site, and priority access to our WordPress experts.',
'jetpack'); ?>
</li>
</ul>
<p>
<?php
esc_html_e( 'Connect to WordPress.com to get started',
'jetpack'
);
?>
<a href="https://jetpack.com/features" target="_blank">
<?php esc_html_e( 'or visit our site for the full feature list.', 'jetpack' ); ?>
</a>
<?php esc_html_e( 'Set up Jetpack to get started or visit our site to learn more about', 'jetpack' ); ?>
<a href="https://jetpack.com/features" target="_blank"><?php esc_html_e( 'all of our features.', 'jetpack' ); ?></a>
</p>

<p class="jp-banner__button-container">
Expand Down
Loading